Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: chrome/browser/metrics/variations_service.cc

Issue 10764005: Added tests for storing and loading seed data to and from prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more merge conflicts Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/variations_service.h ('k') | chrome/browser/metrics/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations_service.cc
diff --git a/chrome/browser/metrics/variations_service.cc b/chrome/browser/metrics/variations_service.cc
index 81a2cd4c8e37529d55311c4b61f79710369aba55..5dca9a86fe85f7d9dfc097f05ce28133ad53b9d7 100644
--- a/chrome/browser/metrics/variations_service.cc
+++ b/chrome/browser/metrics/variations_service.cc
@@ -190,7 +190,7 @@ void VariationsService::RegisterPrefs(PrefService* prefs) {
base::Time().ToInternalValue());
}
-void VariationsService::StoreSeedData(const std::string& seed_data,
+bool VariationsService::StoreSeedData(const std::string& seed_data,
const base::Time& seed_date,
PrefService* local_prefs) {
// Only store the seed data if it parses correctly.
@@ -198,19 +198,20 @@ void VariationsService::StoreSeedData(const std::string& seed_data,
if (!seed.ParseFromString(seed_data)) {
VLOG(1) << "Variations Seed data from server is not in valid proto format, "
<< "rejecting the seed.";
- return;
+ return false;
}
std::string base64_seed_data;
if (!base::Base64Encode(seed_data, &base64_seed_data)) {
VLOG(1) << "Variations Seed data from server fails Base64Encode, rejecting "
<< "the seed.";
- return;
+ return false;
}
local_prefs->SetString(prefs::kVariationsSeed, base64_seed_data);
local_prefs->SetInt64(prefs::kVariationsSeedDate,
seed_date.ToInternalValue());
+ return true;
}
// static
« no previous file with comments | « chrome/browser/metrics/variations_service.h ('k') | chrome/browser/metrics/variations_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698