Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10763011: Remove several usages of linked_ptr in spdy land. (Closed)

Created:
8 years, 5 months ago by Ryan Hamilton
Modified:
8 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove several usages of linked_ptr in spdy land. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -54 lines) Patch
M net/spdy/buffered_spdy_framer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer_spdy2_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/spdy/buffered_spdy_framer_spdy3_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/spdy_session.cc View 10 chunks +13 lines, -14 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Hamilton
8 years, 5 months ago (2012-07-09 21:32:47 UTC) #1
Ryan Sleevi
LGTM, but consider running it through a _valgrind bot just in case (would have caught ...
8 years, 5 months ago (2012-07-09 22:53:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10763011/1
8 years, 5 months ago (2012-07-10 18:32:41 UTC) #3
commit-bot: I haz the power
Try job failure for 10763011-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 20:03:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10763011/1
8 years, 5 months ago (2012-07-10 20:08:20 UTC) #5
commit-bot: I haz the power
Try job failure for 10763011-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 21:47:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10763011/1
8 years, 5 months ago (2012-07-11 04:24:11 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 05:46:40 UTC) #8 
Change committed as 146062

Powered by Google App Engine
This is Rietveld 408576698