Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: net/spdy/buffered_spdy_framer.cc

Issue 10763011: Remove several usages of linked_ptr in spdy land. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/buffered_spdy_framer_spdy2_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace { 9 namespace {
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 bool BufferedSpdyFramer::OnControlFrameHeaderData(SpdyStreamId stream_id, 92 bool BufferedSpdyFramer::OnControlFrameHeaderData(SpdyStreamId stream_id,
93 const char* header_data, 93 const char* header_data,
94 size_t len) { 94 size_t len) {
95 CHECK_EQ(header_stream_id_, stream_id); 95 CHECK_EQ(header_stream_id_, stream_id);
96 96
97 if (len == 0) { 97 if (len == 0) {
98 // Indicates end-of-header-block. 98 // Indicates end-of-header-block.
99 CHECK(header_buffer_valid_); 99 CHECK(header_buffer_valid_);
100 100
101 const linked_ptr<SpdyHeaderBlock> headers(new SpdyHeaderBlock); 101 SpdyHeaderBlock headers;
102 bool parsed_headers = spdy_framer_.ParseHeaderBlockInBuffer( 102 bool parsed_headers = spdy_framer_.ParseHeaderBlockInBuffer(
103 header_buffer_, header_buffer_used_, headers.get()); 103 header_buffer_, header_buffer_used_, &headers);
104 if (!parsed_headers) { 104 if (!parsed_headers) {
105 visitor_->OnStreamError( 105 visitor_->OnStreamError(
106 stream_id, "Could not parse Spdy Control Frame Header."); 106 stream_id, "Could not parse Spdy Control Frame Header.");
107 return false; 107 return false;
108 } 108 }
109 DCHECK(control_frame_fields_.get()); 109 DCHECK(control_frame_fields_.get());
110 switch (control_frame_fields_->type) { 110 switch (control_frame_fields_->type) {
111 case SYN_STREAM: 111 case SYN_STREAM:
112 visitor_->OnSynStream(control_frame_fields_->stream_id, 112 visitor_->OnSynStream(control_frame_fields_->stream_id,
113 control_frame_fields_->associated_stream_id, 113 control_frame_fields_->associated_stream_id,
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 307
308 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) { 308 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
309 memset(header_buffer_, 0, kHeaderBufferSize); 309 memset(header_buffer_, 0, kHeaderBufferSize);
310 header_buffer_used_ = 0; 310 header_buffer_used_ = 0;
311 header_buffer_valid_ = true; 311 header_buffer_valid_ = true;
312 header_stream_id_ = stream_id; 312 header_stream_id_ = stream_id;
313 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream); 313 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream);
314 } 314 }
315 315
316 } // namespace net 316 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/buffered_spdy_framer_spdy2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698