|
Refactors DeviceOrientation to make it more extensible
This refactors the ProviderImpl in DeviceOrientation to make it more general.
This will make it easy to add other types of device data (such as DeviceMotion)
in the future and to have them use the same Provider/ProviderImpl.
This is an alternative to http://codereview.chromium.org/10689106.
TBR=avi
BUG=none
TEST=browser_tests:DeviceOrientationBrowserTest.BasicTest,
content_unittests --gtest_filter=DeviceOrientation*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149864
Total comments: 1
Total comments: 38
Total comments: 46
Total comments: 16
Total comments: 10
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+816 lines, -486 lines) |
Patch |
|
M |
content/browser/device_orientation/accelerometer_mac.h
|
View
|
1
2
3
4
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/accelerometer_mac.cc
|
View
|
1
2
3
4
|
4 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/data_fetcher.h
|
View
|
1
2
3
4
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/data_fetcher_impl_android.h
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/data_fetcher_impl_android.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+12 lines, -5 lines |
0 comments
|
Download
|
|
A |
content/browser/device_orientation/device_data.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/device_orientation_browsertest.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+17 lines, -11 lines |
0 comments
|
Download
|
|
A + |
content/browser/device_orientation/message_filter.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+16 lines, -14 lines |
0 comments
|
Download
|
|
A |
content/browser/device_orientation/message_filter.cc
|
View
|
1
2
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
A |
content/browser/device_orientation/observer_delegate.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+45 lines, -0 lines |
0 comments
|
Download
|
|
A |
content/browser/device_orientation/observer_delegate.cc
|
View
|
1
2
3
4
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/orientation.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+15 lines, -38 lines |
0 comments
|
Download
|
|
A |
content/browser/device_orientation/orientation.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+70 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/orientation_message_filter.h
|
View
|
1
2
|
2 chunks |
+2 lines, -14 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/orientation_message_filter.cc
|
View
|
1
2
3
4
|
3 chunks |
+4 lines, -75 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/provider.h
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+13 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/provider_impl.h
|
View
|
1
2
3
4
5
6
7
|
5 chunks |
+17 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/provider_impl.cc
|
View
|
1
2
3
4
5
6
7
8
|
10 chunks |
+115 lines, -91 lines |
0 comments
|
Download
|
|
M |
content/browser/device_orientation/provider_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
10 chunks |
+329 lines, -205 lines |
0 comments
|
Download
|
|
M |
content/content_browser.gypi
|
View
|
1
2
3
4
5
6
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
Total messages: 22 (0 generated)
|