Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tools/isolate/run_test_from_archive_smoke_test.py

Issue 10753006: get_native_path_case() now preserves the trailing os.sep.path and work with non-existing path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/isolate_smoke_test.py ('k') | tools/isolate/trace_inputs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/run_test_from_archive_smoke_test.py
diff --git a/tools/isolate/run_test_from_archive_smoke_test.py b/tools/isolate/run_test_from_archive_smoke_test.py
index 686249e8f411d63d37bdcd85dbb290c421a19186..7c2d9e10dd8ae0ee9fcaee8e26ab7916a2d5415b 100755
--- a/tools/isolate/run_test_from_archive_smoke_test.py
+++ b/tools/isolate/run_test_from_archive_smoke_test.py
@@ -104,7 +104,10 @@ class RunTestFromArchive(unittest.TestCase):
'--cache', self.cache,
'--remote', self.table,
]
- proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ proc = subprocess.Popen(
+ cmd,
+ stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+ universal_newlines=True)
out, err = proc.communicate()
self.assertEquals(1070, len(out))
self.assertEquals('', err)
@@ -132,7 +135,10 @@ class RunTestFromArchive(unittest.TestCase):
'--cache', self.cache,
'--remote', self.table,
]
- proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ proc = subprocess.Popen(
+ cmd,
+ stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+ universal_newlines=True)
out, err = proc.communicate()
self.assertEquals(1070, len(out))
self.assertEquals('', err)
@@ -146,7 +152,10 @@ class RunTestFromArchive(unittest.TestCase):
'--cache', self.cache,
'--remote', self.table,
]
- proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ proc = subprocess.Popen(
+ cmd,
+ stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+ universal_newlines=True)
out, err = proc.communicate()
self.assertEquals('', out)
self.assertEquals('No file to map\n', err)
« no previous file with comments | « tools/isolate/isolate_smoke_test.py ('k') | tools/isolate/trace_inputs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698