Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/isolate/isolate_smoke_test.py

Issue 10753006: get_native_path_case() now preserves the trailing os.sep.path and work with non-existing path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/isolate/run_test_from_archive_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate_smoke_test.py
diff --git a/tools/isolate/isolate_smoke_test.py b/tools/isolate/isolate_smoke_test.py
index e199f91379f3e2e37f0968ca65408fde1704ebfa..294f31c91a852e0417b3c3343138b7793e7cc572 100755
--- a/tools/isolate/isolate_smoke_test.py
+++ b/tools/isolate/isolate_smoke_test.py
@@ -606,7 +606,8 @@ class Isolate_trace_read_merge(IsolateModeBase):
LEVEL = isolate.STATS_ONLY
def _check_merge(self, filename):
- filepath = os.path.join(ROOT_DIR, 'data', 'isolate', filename)
+ filepath = isolate.trace_inputs.get_native_path_case(
+ os.path.join(ROOT_DIR, 'data', 'isolate', filename))
expected = 'Updating %s\n' % filepath
with open(filepath, 'rb') as f:
old_content = f.read()
@@ -883,8 +884,8 @@ class IsolateNoOutdir(IsolateBase):
self.assertEquals(self._wrap_in_condition(expected), output)
output = self._execute('merge', [], True)
- expected = 'Updating %s\n' % os.path.join(
- self.root, 'data', 'isolate', 'touch_root.isolate')
+ expected = 'Updating %s\n' % isolate.trace_inputs.get_native_path_case(
+ os.path.join(self.root, 'data', 'isolate', 'touch_root.isolate'))
self.assertEquals(expected, output)
# In theory the file is going to be updated but in practice its content
# won't change.
« no previous file with comments | « no previous file | tools/isolate/run_test_from_archive_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698