Issue 10753006: get_native_path_case() now preserves the trailing os.sep.path and work with non-existing path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10753006: get_native_path_case() now preserves the trailing os.sep.path and work with non-existing path. (Closed)

Created:
8 years, 5 months ago by M-A Ruel

Modified:
8 years, 5 months ago

Reviewers:
cmp

CC:
chromium-reviews, pam+watch_chromium.org, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

get_native_path_case() now preserves the trailing os.sep.path and work with non-existing path. This simplifies a few code paths. Add unit test to make sure the behavior is consistent accross platforms. Fixes test regressions. R=cmp@chromium.org NOTRY=true BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146137

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -28 lines)			Patch
M	tools/isolate/isolate_smoke_test.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tools/isolate/run_test_from_archive_smoke_test.py	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	tools/isolate/trace_inputs.py	View	5 chunks	+30 lines, -17 lines	0 comments	Download
M	tools/isolate/trace_inputs_test.py	View	1 chunk	+40 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10753006/1

8 years, 5 months ago (2012-07-11 17:39:06 UTC) #3

Change committed as 146137

Expand Messages | Collapse Messages