Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10750017: Extensions Docs Server: Intro data source (Closed)

Created:
8 years, 5 months ago by cduvall
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, clintstaley, chebert
Visibility:
Public.

Description

Extensions Docs Server: Intro data source An implementation of the intro data source. This data source is used to get the intros for the APIs as well as construct the table of contents entries. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145818

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixes #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -3645 lines) Patch
M chrome/common/extensions/docs/server2/echo_handler.py View 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/intro_data_source.py View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/path_utils.py View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/subversion_fetcher.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source_test.py View 1 2 4 chunks +18 lines, -16 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/bookmarks.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/browserAction.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/browsingData.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/contentSettings.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/contextMenus.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/cookies.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/debugger.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/declarativeWebRequest.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/devtools.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/downloads.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_app.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_discovery.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_fontSettings.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_infobars.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_keybinding.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/experimental_speechInput.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/extension.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/fileBrowserHandler.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/history.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/i18n.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/idle.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/management.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/omnibox.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/pageAction.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/pageCapture.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/permissions.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/privacy.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/proxy.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/storage.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/tabs.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/topSites.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/tts.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/ttsEngine.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/types.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/webNavigation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/webRequest.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/intros/windows.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/bookmarks_intro.html View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/browserAction_intro.html View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/browsingData_intro.html View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/contentSettings_intro.html View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/contextMenus_intro.html View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/cookies_intro.html View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/debugger_intro.html View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/declarativeWebRequest_intro.html View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/devtools_intro.html View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/downloads_intro.html View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_app_intro.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_discovery_intro.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_fontSettings_intro.html View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_infobars_intro.html View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_keybinding_intro.html View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/experimental_speechInput_intro.html View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/extension_intro.html View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/fileBrowserHandler_intro.html View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/history_intro.html View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/i18n_intro.html View 1 chunk +0 lines, -483 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/idle_intro.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/management_intro.html View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/omnibox_intro.html View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/pageAction_intro.html View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/pageCapture_intro.html View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/permissions_intro.html View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/privacy_intro.html View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/proxy_intro.html View 1 chunk +0 lines, -187 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/private/standard_api.html View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/storage_intro.html View 1 chunk +0 lines, -125 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/private/table_of_contents.html View 1 chunk +10 lines, -0 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/tabs_intro.html View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/topSites_intro.html View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/ttsEngine_intro.html View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/tts_intro.html View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/types_intro.html View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/webNavigation_intro.html View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/webRequest_intro.html View 1 chunk +0 lines, -276 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/windows_intro.html View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/bookmarks.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/browserAction.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/browsingData.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/contentSettings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/contextMenus.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/cookies.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/debugger.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/declarativeWebRequest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/devtools.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_app.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_discovery.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_fontSettings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_infobars.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_inputUI.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_keybinding.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/experimental_speechInput.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/extension.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/fileBrowserHandler.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/history.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/i18n.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/idle.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/management.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/omnibox.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/pageAction.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/pageCapture.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/permissions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/privacy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/storage.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/tabs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/topSites.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/tts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/ttsEngine.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/types.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/webNavigation.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/webRequest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/templates/public/windows.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
cduvall
Intro data source!
8 years, 5 months ago (2012-07-10 00:48:25 UTC) #1
not at google - send to devlin
http://codereview.chromium.org/10750017/diff/1/chrome/common/extensions/docs/server2/intro_data_source.py File chrome/common/extensions/docs/server2/intro_data_source.py (right): http://codereview.chromium.org/10750017/diff/1/chrome/common/extensions/docs/server2/intro_data_source.py#newcode35 chrome/common/extensions/docs/server2/intro_data_source.py:35: real_path = safe_key + '.html' Pull this into a ...
8 years, 5 months ago (2012-07-10 01:00:19 UTC) #2
cduvall
http://codereview.chromium.org/10750017/diff/1/chrome/common/extensions/docs/server2/intro_data_source.py File chrome/common/extensions/docs/server2/intro_data_source.py (right): http://codereview.chromium.org/10750017/diff/1/chrome/common/extensions/docs/server2/intro_data_source.py#newcode35 chrome/common/extensions/docs/server2/intro_data_source.py:35: real_path = safe_key + '.html' On 2012/07/10 01:00:20, kalman ...
8 years, 5 months ago (2012-07-10 01:13:14 UTC) #3
not at google - send to devlin
lgtm http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/docs/server2/path_utils.py File chrome/common/extensions/docs/server2/path_utils.py (right): http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/docs/server2/path_utils.py#newcode9 chrome/common/extensions/docs/server2/path_utils.py:9: index = key.rfind('.html') We should be using endswith? ...
8 years, 5 months ago (2012-07-10 01:18:37 UTC) #4
cduvall
8 years, 5 months ago (2012-07-10 01:23:37 UTC) #5 
http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/path_utils.py (right):

http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/path_utils.py:9: index =
key.rfind('.html')
On 2012/07/10 01:18:37, kalman wrote:
> We should be using endswith? This would match something like "foo.html.txt".

Done.

http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/template_data_source_test.py (right):

http://codereview.chromium.org/10750017/diff/2002/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/template_data_source_test.py:32: def
_TemplateDataSourceFactory(self, input_dict, cache_builder):
On 2012/07/10 01:18:37, kalman wrote:
> I'd have called it _CreateTemplateDataSource.

Done.

Powered by Google App Engine
This is Rietveld 408576698