Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10745003: Properly retain non-node event listeners. (Closed)

Created:
8 years, 5 months ago by podivilov
Modified:
8 years, 5 months ago
Reviewers:
Anton Muhin
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Properly retain non-node event listeners. R=antonm@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=689

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -39 lines) Patch
M Source/WebCore/bindings/dart/DartDOMData.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/dart/DartDOMWrapper.h View 1 4 chunks +28 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/dart/DartGCController.cpp View 1 6 chunks +58 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 5 months ago (2012-07-09 16:04:49 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h File Source/WebCore/bindings/dart/DartDOMWrapper.h (right): https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h#newcode230 Source/WebCore/bindings/dart/DartDOMWrapper.h:230: struct DartDOMWrapperEventTargetTraits {}; ditto for too complicated way to ...
8 years, 5 months ago (2012-07-09 16:11:08 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h File Source/WebCore/bindings/dart/DartDOMWrapper.h (right): https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h#newcode230 Source/WebCore/bindings/dart/DartDOMWrapper.h:230: struct DartDOMWrapperEventTargetTraits {}; On 2012/07/09 16:11:08, antonmuhin wrote: > ...
8 years, 5 months ago (2012-07-10 08:35:45 UTC) #3
Anton Muhin
8 years, 5 months ago (2012-07-10 08:39:26 UTC) #4
lgtm

https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/binding...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

https://chromiumcodereview.appspot.com/10745003/diff/1/Source/WebCore/binding...
Source/WebCore/bindings/dart/DartDOMWrapper.h:230: struct
DartDOMWrapperEventTargetTraits {};
Yes, you're right, sorry.

On 2012/07/10 08:35:45, podivilov wrote:
> On 2012/07/09 16:11:08, antonmuhin wrote:
> > ditto for too complicated way to customize behaviour
> 
> I don't know any simpler way to achieve that. Conditional logic won't compile
> because of wrong types.

Powered by Google App Engine
This is Rietveld 408576698