Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: content/shell/layout_test_controller.js

Issue 10740002: Stub out not yet implemented controller methods, so we don't have to wait for timeouts but fail imm… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_shell.gypi ('k') | content/shell/layout_test_controller_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/layout_test_controller.js
diff --git a/content/shell/layout_test_controller.js b/content/shell/layout_test_controller.js
index 1ace50cadc0d9c4931b5438dea394dd73e2c9577..43527e1f2ece5da99d598f812680c5fc87d12b65 100644
--- a/content/shell/layout_test_controller.js
+++ b/content/shell/layout_test_controller.js
@@ -4,6 +4,10 @@
var layoutTestController = layoutTestController || {};
var testRunner = testRunner || {};
+var accessibilityController = accessibilityController || {};
+var gamepadController = gamepadController || {};
+var eventSender = eventSender || {};
+var textInputController = textInputController || {};
(function() {
native function NotifyDone();
@@ -13,16 +17,49 @@ var testRunner = testRunner || {};
native function SetShouldStayOnPageAfterHandlingBeforeUnload();
native function SetWaitUntilDone();
- layoutTestController = new function() {
- this.notifyDone = NotifyDone;
- this.dumpAsText = SetDumpAsText;
- this.dumpChildFramesAsText = SetDumpChildFramesAsText;
- this.setPrinting = SetPrinting;
- this.setShouldStayOnPageAfterHandlingBeforeUnload =
- SetShouldStayOnPageAfterHandlingBeforeUnload;
- this.waitUntilDone = SetWaitUntilDone;
- }();
+ native function NotImplemented();
- testRunner = layoutTestController;
+ var DefaultHandler = function(name) {
+ var handler = {
+ get: function(receiver, property) {
+ return function() {
+ return NotImplemented(name, property);
+ }
+ }
+ }
+ return Proxy.create(handler);
+ }
+ var LayoutTestController = function() {
+ Object.defineProperty(this, "notifyDone", {value: NotifyDone});
+ Object.defineProperty(this, "dumpAsText", {value: SetDumpAsText});
+ Object.defineProperty(this,
+ "dumpChildFramesAsText",
+ {value: SetDumpChildFramesAsText});
+ Object.defineProperty(this, "setPrinting", {value: SetPrinting});
+ Object.defineProperty(
+ this,
+ "setShouldStayOnPageAfterHandlingBeforeUnload",
+ {value: SetShouldStayOnPageAfterHandlingBeforeUnload});
+ Object.defineProperty(this, "waitUntilDone", {value: SetWaitUntilDone});
+ }
+ LayoutTestController.prototype = DefaultHandler("layoutTestController");
+ layoutTestController = new LayoutTestController();
+ testRunner = new LayoutTestController();
+
+ var AccessibilityController = function() {}
+ AccessibilityController.prototype = DefaultHandler("accessibilityController");
+ accessibilityController = new AccessibilityController();
+
+ var GamepadController = function() {}
+ GamepadController.prototype = DefaultHandler("gamepadController");
+ gamepadController = new GamepadController();
+
+ var EventSender = function() {}
+ EventSender.prototype = DefaultHandler("eventSender");
+ eventSender = new EventSender();
+
+ var TextInputController = function() {}
+ TextInputController.prototype = DefaultHandler("textInputController");
+ textInputController = new TextInputController();
})();
« no previous file with comments | « content/content_shell.gypi ('k') | content/shell/layout_test_controller_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698