Issue 10736069: Merge 118589 - Fix for self-closing <use> tags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736069: Merge 118589 - Fix for self-closing <use> tags (Closed)

Created:
8 years, 5 months ago by pdr.

Modified:
7 years, 8 months ago

Reviewers:
pdr, dharani1

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Visibility:
Public.

More Reviews

Description

Merge 118589 - Fix for self-closing <use> tags https://bugs.webkit.org/show_bug.cgi?id=87504 Reviewed by Adam Barth. Source/WebCore: This change causes self-closing non-html tags to behave the same as tags immediately followed by the closing tag. Test: svg/custom/svg-self-closing-use.html * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attachLater): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::insertForeignElement): * html/parser/HTMLConstructionSite.h: (HTMLConstructionSite): LayoutTests: * svg/custom/svg-self-closing-use-expected.html: Added. * svg/custom/svg-self-closing-use.html: Added. TBR=pdr@google.com

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -5 lines)			Patch
A +	LayoutTests/svg/custom/svg-self-closing-use.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/custom/svg-self-closing-use-expected.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/html/parser/HTMLConstructionSite.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/html/parser/HTMLConstructionSite.cpp	View	3 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages