Issue 10736024: Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchro…

Issue 10736024: Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchro… (Closed)

Created:
8 years, 5 months ago by kinuko

Modified:
8 years, 5 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch. BUG=121479 Review URL: https://chromiumcodereview.appspot.com/10704073 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146078

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -198 lines)			Patch
M	chrome/common/extensions/api/input_ime.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context_set.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/event_unittest.cc	View	3 chunks	+1 line, -27 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	3 chunks	+1 line, -32 lines	0 comments	Download
M	chrome/renderer/module_system.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/module_system.cc	View	4 chunks	+7 lines, -16 lines	0 comments	Download
M	chrome/renderer/resources/extensions/event.js	View	7 chunks	+38 lines, -41 lines	0 comments	Download
M	chrome/renderer/resources/extensions/experimental.app_custom_bindings.js	View	1 chunk	+47 lines, -47 lines	0 comments	Download
M	chrome/renderer/resources/extensions/input.ime_custom_bindings.js	View	1 chunk	+23 lines, -10 lines	0 comments	Download
M	chrome/renderer/resources/extensions/omnibox_custom_bindings.js	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	chrome/renderer/resources/extensions/tts_engine_custom_bindings.js	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	chrome/test/base/module_system_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

On 2012/07/11 07:30:55, kinuko wrote: We suspect this change might have caused crashy failures in ...

8 years, 5 months ago (2012-07-11 07:32:10 UTC) #2

kinuko

8 years, 5 months ago (2012-07-11 08:09:26 UTC) #3

On 2012/07/11 07:32:10, kinuko wrote:
> On 2012/07/11 07:30:55, kinuko wrote:
> 
> We suspect this change might have caused crashy failures in chromeos
> browser_tests:
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%2520ChromiumOS...
> 
> (Will revert the revert if it doesn't fix)

It looks like the revert fixed the breakage.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Expand Messages | Collapse Messages