Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: chrome/renderer/extensions/event_unittest.cc

Issue 10736024: Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchro… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/event_unittest.cc
===================================================================
--- chrome/renderer/extensions/event_unittest.cc (revision 146077)
+++ chrome/renderer/extensions/event_unittest.cc (working copy)
@@ -65,8 +65,6 @@
"exports.sendRequest = function() {};");
OverrideNativeHandler("apiDefinitions",
"exports.GetExtensionAPIDefinition = function() {};");
- OverrideNativeHandler("logging",
- "exports.DCHECK = function() {};");
}
};
@@ -150,7 +148,7 @@
"var e = new event.Event('myevent');"
"var called = false;"
"e.addListener(function() { called = true; });"
- "chromeHidden.Event.dispatchJSON('myevent', []);"
+ "chromeHidden.Event.dispatch('myevent', []);"
"assert.AssertTrue(called);");
module_system_->Require("test");
}
@@ -248,28 +246,4 @@
module_system_->Require("test");
}
-TEST_F(EventUnittest, MaxListeners) {
- ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
- RegisterModule("test",
- "var event = require('event');"
- "var assert = requireNative('assert');"
- "var eventOpts = {supportsListeners: true, maxListeners: 1};"
- "var e = new event.Event('myevent', undefined, eventOpts);"
- "var cb = function() {};"
- "var caught = false;"
- "try {"
- " e.addListener(cb);"
- "} catch (e) {"
- " caught = true;"
- "}"
- "assert.AssertTrue(!caught);"
- "try {"
- " e.addListener(cb);"
- "} catch (e) {"
- " caught = true;"
- "}"
- "assert.AssertTrue(caught);");
- module_system_->Require("test");
-}
-
} // namespace
« no previous file with comments | « chrome/renderer/extensions/chrome_v8_context_set.cc ('k') | chrome/renderer/extensions/extension_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698