Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10735076: Update swarm to run from the Dart Editor with demo data (Closed)

Created:
8 years, 5 months ago by vsm
Modified:
8 years, 5 months ago
Reviewers:
Bob Nystrom, sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update swarm to run from the Dart Editor with demo data Note: user.data is a binary file matching the encoded string in the old CannedData.dart. This doesn't fix the stale AppEngine instructions. Committed: https://code.google.com/p/dart/source/detail?r=9617

Patch Set 1 #

Patch Set 2 : Update README #

Total comments: 4

Patch Set 3 : Fixed some typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -150 lines) Patch
D samples/swarm/CannedData.dart View 1 chunk +0 lines, -106 lines 0 comments Download
M samples/swarm/DataSource.dart View 1 2 4 chunks +14 lines, -32 lines 0 comments Download
M samples/swarm/README View 1 1 chunk +18 lines, -11 lines 0 comments Download
A samples/swarm/data/Test0_0_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_0_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_1_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_2_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test0_3_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_0_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_1_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_2_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test1_3_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_0_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_1_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_2_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_0.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_1.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_2.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_3.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_4.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_5.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_6.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/Test2_3_7.html View 1 chunk +1 line, -0 lines 0 comments Download
A samples/swarm/data/user.data View 0 chunks +-1 lines, --1 lines 0 comments Download
M samples/swarm/swarmlib.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years, 5 months ago (2012-07-12 18:07:14 UTC) #1
Bob Nystrom
Couple of nits but LGTM! https://chromiumcodereview.appspot.com/10735076/diff/1001/samples/swarm/DataSource.dart File samples/swarm/DataSource.dart (right): https://chromiumcodereview.appspot.com/10735076/diff/1001/samples/swarm/DataSource.dart#newcode59 samples/swarm/DataSource.dart:59: })); -2 indent on ...
8 years, 5 months ago (2012-07-12 21:10:08 UTC) #2
vsm
8 years, 5 months ago (2012-07-12 21:49:44 UTC) #3 
Thanks for the review!  Landing.

https://chromiumcodereview.appspot.com/10735076/diff/1001/samples/swarm/DataS...
File samples/swarm/DataSource.dart (right):

https://chromiumcodereview.appspot.com/10735076/diff/1001/samples/swarm/DataS...
samples/swarm/DataSource.dart:59: }));
Hmm, the editor seems to want this indent ... but fixed as you suggest.

On 2012/07/12 21:10:08, Bob Nystrom wrote:
> -2 indent on the })); line.

https://chromiumcodereview.appspot.com/10735076/diff/1001/samples/swarm/DataS...
samples/swarm/DataSource.dart:210: // TODO(jimhug): Remove this truly evil
synchronoush xhr.
On 2012/07/12 21:10:08, Bob Nystrom wrote:
> "synchronous"

Done.

Powered by Google App Engine
This is Rietveld 408576698