Issue 10735048: Revert 146065 - Remove app shortcuts when app is uninstalled on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735048: Revert 146065 - Remove app shortcuts when app is uninstalled on Linux. (Closed)

Created:
8 years, 5 months ago by benwells

Modified:
8 years, 5 months ago

Reviewers:
benwells

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 146065 - Remove app shortcuts when app is uninstalled on Linux. To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first. Web page shortcuts are not affected. BUG=130456 TEST=Test uninstalling apps removes their shortcuts; test uninstalling apps is not broken in any way; test shortcuts for web apps are not broken in any way. Review URL: https://chromiumcodereview.appspot.com/10698114 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146066

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -138 lines)			Patch
M	chrome/browser/extensions/app_shortcut_manager.cc	View	2 chunks	+9 lines, -24 lines	0 comments	Download
M	chrome/browser/shell_integration_linux.h	View	2 chunks	+1 line, -17 lines	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View	6 chunks	+3 lines, -62 lines	0 comments	Download
M	chrome/browser/shell_integration_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/web_applications/web_app.h	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/web_applications/web_app.cc	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_linux.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_win.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages