Remove app shortcuts when app is uninstalled on Linux.

Remove app shortcuts when app is uninstalled on Linux.

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146065

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146094

[benwells, 2012-07-09 01:50:59]

+koz for local sanity
+mihai for app specific check

[koz (OOO until 15th September), 2012-07-10 00:23:51]

Code looks sane to me, but I'm not familiar with this code, so I'll leave to
Mihai to lgt m.

https://chromiumcodereview.appspot.com/10698114/diff/3003/chrome/browser/exte...
File chrome/browser/extensions/app_shortcut_manager.cc (right):

https://chromiumcodereview.appspot.com/10698114/diff/3003/chrome/browser/exte...
chrome/browser/extensions/app_shortcut_manager.cc:67: if (type ==
chrome::NOTIFICATION_EXTENSION_INSTALLED) {
if / else if / else -> switch?

[Mihai Parparita -not on Chrome, 2012-07-10 22:51:27]

http://codereview.chromium.org/10698114/diff/3003/chrome/browser/shell_integr...
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/10698114/diff/3003/chrome/browser/shell_integr...
chrome/browser/shell_integration_linux.cc:591: cmd_line =
ShellIntegration::CommandLineArgsForLauncher(
Encoding this data in the filename seems ugly (users can see that, right?).

Since we have it in the command-line for the shortcut, can we extract it from
there?

[benwells, 2012-07-10 22:55:51]

http://codereview.chromium.org/10698114/diff/3003/chrome/browser/shell_integr...
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/10698114/diff/3003/chrome/browser/shell_integr...
chrome/browser/shell_integration_linux.cc:591: cmd_line =
ShellIntegration::CommandLineArgsForLauncher(
On 2012/07/10 22:51:27, Mihai Parparita wrote:
> Encoding this data in the filename seems ugly (users can see that, right?).
> 
> Since we have it in the command-line for the shortcut, can we extract it from
> there?

It's not visible to users. Currently the filename for shortcuts is something
like chrome-__1.desktop. I don't think iterating through all shortcuts and menu
items, opening them up to look at the shortcuts, is better. I don't know if it
is possible in a desktop environment neutral way for the menus.

[Mihai Parparita -not on Chrome, 2012-07-11 00:06:40]

LGTM, but please implement koz's suggestion before landing.

[commit-bot: I haz the power, 2012-07-11 04:45:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10698114/9002

[commit-bot: I haz the power, 2012-07-11 06:10:10]

Change committed as 146065

[commit-bot: I haz the power, 2012-07-11 08:44:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10698114/9003

[commit-bot: I haz the power, 2012-07-11 09:50:52]

Change committed as 146094