Adds helper methods for WebView.

Adds helper methods for WebView.

Adds some static methods to help webview implementation.

INTERNAL-BUG=6741903
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146624

[aurimas (slooooooooow), 2012-06-27 21:37:12]

Hello Darin,

I have upstreamed a small change adding a few static methods for WebView. Could
you please check it out? Thanks!

Aurimas

[aurimas (slooooooooow), 2012-06-27 22:26:23]

I've added John to look over the files.

Aurimas

[John Grabowski, 2012-06-28 17:08:06]

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/app/androi...
File content/app/android/content_jni_registrar.cc (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/app/androi...
content/app/android/content_jni_registrar.cc:43: //  { "WebSettings",
WebSettings::RegisterWebSettings },
In general Chrome doesn't like to land code that is commented out.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
File content/browser/android/content_view_statics.cc (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:19: using namespace
content::address_parser;
chrome style doesn't like "using namespace".  List classes/methods explicitly.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:21: static jstring
FindAddress(JNIEnv* env, jclass clazz, jstring addr) {
chrome style prefers anon namespaces to static functions.
Also, add single-line comment for this function.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:29: bool
RegisterWebViewStatics(JNIEnv* env) {
all in content napespace

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
File content/browser/android/content_view_statics.h (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.h:5: #ifndef
CONTENT_BROWSER_WEB_VIEW_STATICS_H_
This file lives in content/browser/android so this should be
CONTENT_BROWSER_ANDROID_CONTENT_VIEW_STATISTICS_H_

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.h:9: bool
RegisterWebViewStatics(JNIEnv* env);
content namespace please

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/content_br...
File content/content_browser.gypi (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/content_br...
content/content_browser.gypi:197: 'browser/android/content_view_impl.cc',
files should be listed alphabetically
moving these two above the next two doesn't honor that

[aurimas (slooooooooow), 2012-06-28 23:00:07]

Hey John,

I have followed all your comments, except for the wrapping the FindAddress in
anon namespace. Dan and I tried doing that and JNI had issues finding the
method.

Aurimas

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/app/androi...
File content/app/android/content_jni_registrar.cc (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/app/androi...
content/app/android/content_jni_registrar.cc:43: //  { "WebSettings",
WebSettings::RegisterWebSettings },
On 2012/06/28 17:08:06, John Grabowski wrote:
> In general Chrome doesn't like to land code that is commented out.

Done.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
File content/browser/android/content_view_statics.cc (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:19: using namespace
content::address_parser;
On 2012/06/28 17:08:06, John Grabowski wrote:
> chrome style doesn't like "using namespace".  List classes/methods explicitly.

Done.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:21: static jstring
FindAddress(JNIEnv* env, jclass clazz, jstring addr) {
On 2012/06/28 17:08:06, John Grabowski wrote:
> chrome style prefers anon namespaces to static functions.
> Also, add single-line comment for this function.

I tried putting this function in a anon namespace, however jni had issues
finding this method then.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.cc:29: bool
RegisterWebViewStatics(JNIEnv* env) {
On 2012/06/28 17:08:06, John Grabowski wrote:
> all in content napespace

Done.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
File content/browser/android/content_view_statics.h (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.h:5: #ifndef
CONTENT_BROWSER_WEB_VIEW_STATICS_H_
On 2012/06/28 17:08:06, John Grabowski wrote:
> This file lives in content/browser/android so this should be
> CONTENT_BROWSER_ANDROID_CONTENT_VIEW_STATISTICS_H_

Done.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/browser/an...
content/browser/android/content_view_statics.h:9: bool
RegisterWebViewStatics(JNIEnv* env);
On 2012/06/28 17:08:06, John Grabowski wrote:
> content namespace please

Done.

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/content_br...
File content/content_browser.gypi (right):

https://chromiumcodereview.appspot.com/10706004/diff/17001/content/content_br...
content/content_browser.gypi:197: 'browser/android/content_view_impl.cc',
On 2012/06/28 17:08:06, John Grabowski wrote:
> files should be listed alphabetically
> moving these two above the next two doesn't honor that

Done.

[John Grabowski, 2012-06-28 23:04:54]

LGTM

[commit-bot: I haz the power, 2012-06-28 23:06:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/10706004/12003

[commit-bot: I haz the power, 2012-06-28 23:06:16]

Presubmit check for 10706004-12003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

[aurimas (slooooooooow), 2012-06-28 23:07:17]

Hello Darin,

I just got John's LGTM. Could I get yours as well?

Thanks!
Aurimas

[aurimas (slooooooooow), 2012-07-02 21:07:52]

Hello,

I got an LGTM from John. Could the owners of content/ also take a look at my
change?

Thanks,
Aurimas

[brettw, 2012-07-02 21:54:11]

Please pick one owner and send the review to them rather than spamming people.

[aurimas (slooooooooow), 2012-07-03 18:02:18]

Hello Avi,

Could you please take a look at my CL. I have received an LGTM from John
already.

Thanks,
Aurimas

[aurimas (slooooooooow), 2012-07-12 22:47:39]

Hello Brett,

I was wondering if you could look at my changes? I got an LGTM from John
already.

Thanks,
Aurimas

[brettw, 2012-07-13 17:14:24]

lgtm

https://chromiumcodereview.appspot.com/10706004/diff/17003/content/browser/an...
File content/browser/android/content_view_statics.cc (right):

https://chromiumcodereview.appspot.com/10706004/diff/17003/content/browser/an...
content/browser/android/content_view_statics.cc:36: } // namespace content
Nit: 2 spaces before //

https://chromiumcodereview.appspot.com/10706004/diff/17003/net/android/java/s...
File net/android/java/src/org/chromium/net/ProxyChangeListener.java (right):

https://chromiumcodereview.appspot.com/10706004/diff/17003/net/android/java/s...
net/android/java/src/org/chromium/net/ProxyChangeListener.java:30: public void
proxySettingsChanged();
Is the indenting correct here?

[commit-bot: I haz the power, 2012-07-13 18:10:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/10706004/11014

[commit-bot: I haz the power, 2012-07-13 19:39:33]

Change committed as 146624