Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 10704248: Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values (Closed)

Created:
8 years, 5 months ago by enne (OOO)
Modified:
8 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values https://bugs.webkit.org/show_bug.cgi?id=91438 Reviewed by Kenneth Russell. r120509 turned on blending for scrollbar thumbs. Unfortunately for Windows XP scrollbar thumbs, their alpha channel is bogus and so the thumb ends up being completely transparent. This should ultimately be fixed in Chromium theme code, but in the meantime this patch turns off the use of ScrollbarLayerChromium. This change makes Windows scrollbars fall back to using normal ContentLayerChromiums and being painted all in one layer on the main thread rather than being painted separately and composited on the compositor thread. * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: (WebCore::createScrollbarLayer): TBR=enne@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
enne (OOO)
8 years, 5 months ago (2012-07-17 17:40:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698