Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp

Issue 10704248: Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
===================================================================
--- Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (revision 122853)
+++ Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (working copy)
@@ -120,9 +120,12 @@
if (!scrollbarGraphicsLayer->contentsOpaque())
scrollbarGraphicsLayer->setContentsOpaque(isOpaqueRootScrollbar);
- // FIXME: Mac scrollbar themes are not thread-safe.
+ // FIXME: Mac scrollbar themes are not thread-safe to paint.
+ // FIXME: Win scrollbars on XP Classic themes do not paint valid alpha
+ // values due to GDI. This needs to be fixed in theme code before it
+ // can be turned on here.
bool platformSupported = true;
-#if OS(DARWIN)
+#if OS(DARWIN) || OS(WINDOWS)
platformSupported = false;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698