Issue 10704143: Allow max_group = 0 to pass all groups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704143: Allow max_group = 0 to pass all groups. (Closed)

Created:
8 years, 5 months ago by achuithb

Modified:
8 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Allow max_group = 0 to pass all groups. BUG=NONE TEST=unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146009

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -6 lines)			Patch
M	chrome/browser/web_resource/notification_promo.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/web_resource/notification_promo.cc	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service_unittest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

achuithb

This should allow us to specify increment_max:0 next time. The only danger is that this ...

8 years, 5 months ago (2012-07-10 22:25:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10704143/1

8 years, 5 months ago (2012-07-10 23:30:21 UTC) #4

Change committed as 146009