Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Unified Diff: chrome/browser/web_resource/promo_resource_service_unittest.cc

Issue 10704143: Allow max_group = 0 to pass all groups. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_resource/notification_promo.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_resource/promo_resource_service_unittest.cc
===================================================================
--- chrome/browser/web_resource/promo_resource_service_unittest.cc (revision 145631)
+++ chrome/browser/web_resource/promo_resource_service_unittest.cc (working copy)
@@ -197,6 +197,13 @@
notification_promo_.group_ = i;
EXPECT_TRUE(notification_promo_.CanShow());
}
+
+ // When max_group_ is 0, all groups pass.
+ notification_promo_.max_group_ = 0;
+ for (int i = 0; i < num_groups_; i += incr) {
+ notification_promo_.group_ = i;
+ EXPECT_TRUE(notification_promo_.CanShow());
+ }
}
void TestViews() {
« no previous file with comments | « chrome/browser/web_resource/notification_promo.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698