Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: lib/dom/scripts/idlnode.py

Issue 10704100: Do not split attributes on getters and setters in databasebuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/idlnode.py
diff --git a/lib/dom/scripts/idlnode.py b/lib/dom/scripts/idlnode.py
index 0d2e2df4ebc0b0d8ac99b93ec220b9a698fc2069..d47f58f50e6c4b78d3a9721a66e1d2e9a92c78d6 100755
--- a/lib/dom/scripts/idlnode.py
+++ b/lib/dom/scripts/idlnode.py
@@ -382,8 +382,7 @@ class IDLInterface(IDLNode):
def has_attribute(self, candidate):
for attribute in self.attributes:
if (attribute.id == candidate.id and
Anton Muhin 2012/07/04 15:41:25 if AOO(attribute, candidate) == 0? And, btw, mayb
podivilov 2012/07/04 16:32:47 This is the only place where we compare nodes.
- attribute.is_fc_getter == candidate.is_fc_getter and
- attribute.is_fc_setter == candidate.is_fc_setter):
+ attribute.is_read_only == candidate.is_read_only):
return True
return False
@@ -434,13 +433,8 @@ class IDLAttribute(IDLMember):
or self._convert_first(ast, 'GetRaises', IDLType)
self.set_raises = self.raises \
or self._convert_first(ast, 'SetRaises', IDLType)
- # FremontCut IDL syntax defines getters and setters separately:
- self.is_fc_getter = self._has(ast, 'AttrGetter')
- self.is_fc_setter = self._has(ast, 'AttrSetter')
def _extra_repr(self):
extra = []
- if self.is_fc_getter: extra.append('get')
- if self.is_fc_setter: extra.append('set')
if self.is_read_only: extra.append('readonly')
if self.raises: extra.append('raises')
return extra

Powered by Google App Engine
This is Rietveld 408576698