Do not split attributes on getters and setters in databasebuilder.

lib/dom/scripts/generator.py

Index: lib/dom/scripts/generator.py
diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py
index 2a8bab7544a98327368403e5c4cf80aac889055a..526f1e45e241b7719683328507e7ce9d04505b33 100644
--- a/lib/dom/scripts/generator.py
+++ b/lib/dom/scripts/generator.py
@@ -321,9 +321,7 @@ def IsDartCollectionType(type):
 
 def FindMatchingAttribute(interface, attr1):
   matches = [attr2 for attr2 in interface.attributes
-             if attr1.id == attr2.id
-             and attr1.is_fc_getter == attr2.is_fc_getter
-             and attr1.is_fc_setter == attr2.is_fc_setter]
+             if attr1.id == attr2.id]

[Anton Muhin, 2012/07/04 15:41:25]

should you check readonly'ness here?

[podivilov, 2012/07/04 16:32:47]

Nope, if attribute was declared with different "readonly'ness" in parent, we
still need to shadow it.

   if matches:
     assert len(matches) == 1
     return matches[0]
@@ -461,8 +459,7 @@ def AttributeOutputOrder(a, b):
     # Getters before setters:
   if a.id < b.id: return -1
   if a.id > b.id: return 1
-  if a.is_fc_setter < b.is_fc_setter: return -1
-  if a.is_fc_setter > b.is_fc_setter: return 1
+  if a.is_read_only < b.is_read_only: return -1

[Anton Muhin, 2012/07/04 15:41:25]

shouldn't you have a.is_read_only > b.is_read_only: return 1 her?

[podivilov, 2012/07/04 16:32:47]

Turned out this function isn't used at all :)

   return 0

[Anton Muhin, 2012/07/04 15:41:25]

overall, I'd rather code that as:

def AOO(a, b):
  return cmp([a.id, a.is_read_only], [b.id, b.is_read_only])

 
 def ConstantOutputOrder(a, b):