Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 10704017: Adding Chrome Frame metric for SetSite performance. (Closed)

Created:
8 years, 5 months ago by robertshield
Modified:
8 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Adding Chrome Frame metric for SetSite performance. BUG=134640 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145086

Patch Set 1 #

Total comments: 6

Patch Set 2 : Dear Greg. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome_frame/bho.cc View 1 2 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertshield
8 years, 5 months ago (2012-06-28 03:46:36 UTC) #1
grt (UTC plus 2)
https://chromiumcodereview.appspot.com/10704017/diff/1/chrome_frame/bho.cc File chrome_frame/bho.cc (right): https://chromiumcodereview.appspot.com/10704017/diff/1/chrome_frame/bho.cc#newcode1 chrome_frame/bho.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
8 years, 5 months ago (2012-06-28 13:55:04 UTC) #2
robertshield
https://chromiumcodereview.appspot.com/10704017/diff/1/chrome_frame/bho.cc File chrome_frame/bho.cc (right): https://chromiumcodereview.appspot.com/10704017/diff/1/chrome_frame/bho.cc#newcode1 chrome_frame/bho.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
8 years, 5 months ago (2012-06-28 14:11:13 UTC) #3
grt (UTC plus 2)
lgtm
8 years, 5 months ago (2012-06-28 14:16:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10704017/9001
8 years, 5 months ago (2012-06-28 18:23:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome_frame/bho.cc: While running patch -p1 --forward --force; patching file chrome_frame/bho.cc ...
8 years, 5 months ago (2012-06-28 18:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10704017/3002
8 years, 5 months ago (2012-06-30 18:39:14 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-06-30 19:34:17 UTC) #8
Change committed as 145086

Powered by Google App Engine
This is Rietveld 408576698