Adding Chrome Frame metric for SetSite performance.

chrome_frame/bho.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

[grt (UTC plus 2), 2012/06/28 13:55:04]

2012

[robertshield, 2012/06/28 14:11:14]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/bho.h"
 
 #include <shlguid.h>
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/time.h"
 #include "base/win/scoped_bstr.h"
 #include "chrome_frame/buggy_bho_handling.h"
 #include "chrome_frame/crash_reporting/crash_metrics.h"
 #include "chrome_frame/extra_system_apis.h"
 #include "chrome_frame/html_utils.h"
 #include "chrome_frame/http_negotiate.h"
 #include "chrome_frame/metrics_service.h"
 #include "chrome_frame/protocol_sink_wrap.h"
 #include "chrome_frame/ready_mode/ready_mode.h"
 #include "chrome_frame/urlmon_moniker.h"
@@ skipping 61 matching lines @@
 };  // class ReadyModeDelegateImpl
 
 void ReadyModeDelegateImpl::DisableChromeFrame() {
   HttpNegotiatePatch::set_modify_user_agent(false);
   ProtocolSinkWrap::set_ignore_xua(true);
 }
 
 }  // namespace
 
 STDMETHODIMP Bho::SetSite(IUnknown* site) {
+  base::TimeTicks start = base::TimeTicks::Now();

[grt (UTC plus 2), 2012/06/28 13:55:04]

move this down to line 100?

[robertshield, 2012/06/28 14:11:14]

Done.

+
   HRESULT hr = S_OK;
   if (site) {
     base::win::ScopedComPtr<IWebBrowser2> web_browser2;
     web_browser2.QueryFrom(site);
     if (web_browser2) {
       hr = DispEventAdvise(web_browser2, &DIID_DWebBrowserEvents2);
       DCHECK(SUCCEEDED(hr)) << "DispEventAdvise failed. Error: " << hr;
 
       ready_mode::Configure(new ReadyModeDelegateImpl(), web_browser2);
     }
@@ skipping 13 matching lines @@
     // our active document/activex instances to query referrer and other
     // information for a URL.
     AddRef();
     RegisterThreadInstance();
     MetricsService::Start();
 
     if (!IncreaseWinInetConnections(kMaxHttpConnections)) {
       DLOG(WARNING) << "Failed to bump up HTTP connections. Error:"
                     << ::GetLastError();
     }
+
+    base::TimeDelta delta = base::TimeTicks::Now() - start;
+    UMA_HISTOGRAM_TIMES("ChromeFrame.BhoLoadSetSite", delta);

[grt (UTC plus 2), 2012/06/28 13:55:04]

delta.InMilliseconds()

[robertshield, 2012/06/28 14:11:14]

The macro already does that.

   } else {
     UnregisterThreadInstance();
     buggy_bho::BuggyBhoTls::DestroyInstance();
     base::win::ScopedComPtr<IWebBrowser2> web_browser2;
     web_browser2.QueryFrom(m_spUnkSite);
     DispEventUnadvise(web_browser2, &DIID_DWebBrowserEvents2);
     Release();
   }
 
   return IObjectWithSiteImpl<Bho>::SetSite(site);
@@ skipping 235 matching lines @@
   }
 }
 
 void PatchHelper::UnpatchIfNeeded() {
   if (state_ == PATCH_PROTOCOL) {
     g_trans_hooks.RevertHooks();
     HttpNegotiatePatch::Uninitialize();
   }
   state_ = UNKNOWN;
 }