Issue 10703110: browser/ui: Unify the enum Kind of SadTab used by SadTabViews and SabTabGtk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703110: browser/ui: Unify the enum Kind of SadTab used by SadTabViews and SabTabGtk. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

browser/ui: Unify the enum Kind of SadTab used by SadTabViews and SabTabGtk. We need to consolidate this enum into a single place, that can be used by both classes. This will be used for the views component work (crbug.com/125846). BUG=136248, 125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145868

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -71 lines)			Patch
M	chrome/browser/ui/gtk/sad_tab_gtk.h	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/sad_tab_gtk.cc	View	7 chunks	+18 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/sad_tab_helper.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/sad_tab_helper.cc	View	5 chunks	+13 lines, -17 lines	0 comments	Download
A	chrome/browser/ui/sad_tab_types.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.h	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View	7 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm