Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2320)

Unified Diff: chrome/browser/ui/views/sad_tab_view.h

Issue 10703110: browser/ui: Unify the enum Kind of SadTab used by SadTabViews and SabTabGtk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sad_tab_types.h ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/sad_tab_view.h
diff --git a/chrome/browser/ui/views/sad_tab_view.h b/chrome/browser/ui/views/sad_tab_view.h
index d777755976c20e421100d809ec3ed344d6d33c9a..a404c7395546883e6dee5b36046362a02e10da0d 100644
--- a/chrome/browser/ui/views/sad_tab_view.h
+++ b/chrome/browser/ui/views/sad_tab_view.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "chrome/browser/ui/sad_tab_types.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/link_listener.h"
#include "ui/views/view.h"
@@ -37,14 +38,7 @@ class SadTabView : public views::View,
public views::LinkListener,
public views::ButtonListener {
public:
- // NOTE: Do not remove or reorder the elements in this enum, and only add new
- // items at the end. We depend on these specific values in a histogram.
- enum Kind {
- CRASHED = 0, // Tab crashed. Display the "Aw, Snap!" page.
- KILLED // Tab killed. Display the "He's dead, Jim!" tab page.
- };
-
- SadTabView(content::WebContents* web_contents, Kind kind);
+ SadTabView(content::WebContents* web_contents, chrome::SadTabKind kind);
virtual ~SadTabView();
// Overridden from views::View:
@@ -69,7 +63,7 @@ class SadTabView : public views::View,
views::Link* CreateLink(const string16& text);
content::WebContents* web_contents_;
- Kind kind_;
+ chrome::SadTabKind kind_;
bool painted_;
const gfx::Font& base_font_;
views::Label* message_;
« no previous file with comments | « chrome/browser/ui/sad_tab_types.h ('k') | chrome/browser/ui/views/sad_tab_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698