Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10702166: Do not enter the debugger when debugger is not active. (Closed)

Created:
8 years, 5 months ago by Yang
Modified:
8 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Do not enter the debugger when debugger is not active. R=mstarzinger@chromium.org BUG= TEST=test-debug/DebuggerCreatesContextIffActive Committed: https://code.google.com/p/v8/source/detail?r=12059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M src/execution.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
8 years, 5 months ago (2012-07-12 11:22:38 UTC) #1
Michael Starzinger
8 years, 5 months ago (2012-07-12 11:28:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698