Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Side by Side Diff: src/execution.cc

Issue 10702166: Do not enter the debugger when debugger is not active. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 814 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 // Just continue if breaks are disabled. 825 // Just continue if breaks are disabled.
826 if (isolate->debug()->disable_break()) { 826 if (isolate->debug()->disable_break()) {
827 return isolate->heap()->undefined_value(); 827 return isolate->heap()->undefined_value();
828 } 828 }
829 829
830 // Ignore debug break during bootstrapping. 830 // Ignore debug break during bootstrapping.
831 if (isolate->bootstrapper()->IsActive()) { 831 if (isolate->bootstrapper()->IsActive()) {
832 return isolate->heap()->undefined_value(); 832 return isolate->heap()->undefined_value();
833 } 833 }
834 834
835 // Ignore debug break if debugger is not active.
836 if (!isolate->debugger()->IsDebuggerActive()) {
837 return isolate->heap()->undefined_value();
838 }
839
835 StackLimitCheck check(isolate); 840 StackLimitCheck check(isolate);
836 if (check.HasOverflowed()) { 841 if (check.HasOverflowed()) {
837 return isolate->heap()->undefined_value(); 842 return isolate->heap()->undefined_value();
838 } 843 }
839 844
840 { 845 {
841 JavaScriptFrameIterator it(isolate); 846 JavaScriptFrameIterator it(isolate);
842 ASSERT(!it.done()); 847 ASSERT(!it.done());
843 Object* fun = it.frame()->function(); 848 Object* fun = it.frame()->function();
844 if (fun && fun->IsJSFunction()) { 849 if (fun && fun->IsJSFunction()) {
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
926 } 931 }
927 if (stack_guard->IsInterrupted()) { 932 if (stack_guard->IsInterrupted()) {
928 stack_guard->Continue(INTERRUPT); 933 stack_guard->Continue(INTERRUPT);
929 return isolate->StackOverflow(); 934 return isolate->StackOverflow();
930 } 935 }
931 return isolate->heap()->undefined_value(); 936 return isolate->heap()->undefined_value();
932 } 937 }
933 938
934 939
935 } } // namespace v8::internal 940 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698