Chrome Performance Monitor: Metric API Functions.

Chrome Performance Monitor: Metric API Functions.

Implements the two metric functions specified here:
https://docs.google.com/a/chromium.org/document/d/1GhiAly7eRlkH5wfuGAEy53soLIiWVc-3p7E2phSWlJ0/edit#heading=h.9lk03sdde2hp


BUG=130212
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146680

[Matt Tytel, 2012-07-07 00:42:08]

Some new Metric API functions for review.

[Evan Stade, 2012-07-10 07:59:39]

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/performance_...
File chrome/browser/performance_monitor/performance_monitor_util.h (right):

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/performance_...
chrome/browser/performance_monitor/performance_monitor_util.h:28: bool
PostTaskToDatabaseAndReply(const base::Closure& request,
docs. Also you're not really posting to a database, you're posting to a thread,
so I don't overly much like the name of the function.

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:46: void
DoGetMetric(ListValue* results,
docs

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:165:
MetricTypeToString(metric_type));
indent off by one

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:167: }
\n

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.h (right):

http://codereview.chromium.org/10702117/diff/2001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.h:39: void
HandleGetActiveIntervals(const base::ListValue* args);
the docs for all these functions should mention what the args are.

[Matt Tytel, 2012-07-10 19:08:19]

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/perf...
File chrome/browser/performance_monitor/performance_monitor_util.h (right):

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/perf...
chrome/browser/performance_monitor/performance_monitor_util.h:28: bool
PostTaskToDatabaseAndReply(const base::Closure& request,
On 2012/07/10 07:59:39, Evan Stade wrote:
> docs. Also you're not really posting to a database, you're posting to a
thread,
> so I don't overly much like the name of the function.

Done.

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:46: void
DoGetMetric(ListValue* results,
On 2012/07/10 07:59:39, Evan Stade wrote:
> docs

Done.

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:165:
MetricTypeToString(metric_type));
On 2012/07/10 07:59:39, Evan Stade wrote:
> indent off by one

Done.

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:167: }
On 2012/07/10 07:59:39, Evan Stade wrote:
> \n

Done.

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.h (right):

https://chromiumcodereview.appspot.com/10702117/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.h:39: void
HandleGetActiveIntervals(const base::ListValue* args);
On 2012/07/10 07:59:39, Evan Stade wrote:
> the docs for all these functions should mention what the args are.

Done.

[koz (OOO until 15th September), 2012-07-11 00:19:57]

lgtm

https://chromiumcodereview.appspot.com/10702117/diff/4002/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10702117/diff/4002/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:69:
util::AggregateMetric(*(metric_vector.get()), start, resolution);
*(metric_vector.get()) -> *metric_vector

[Evan Stade, 2012-07-11 00:45:19]

lgtm

[commit-bot: I haz the power, 2012-07-11 01:57:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtytel@chromium.org/10702117/1015

[commit-bot: I haz the power, 2012-07-11 03:13:34]

Try job failure for 10702117-1015 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Matt Tytel, 2012-07-12 19:56:06]

Sorry to bug you guys again, there were some small spec changes to getMetric and
getEvents. Could you take a look again?

[koz (OOO until 15th September), 2012-07-13 02:45:39]

new changes lgtm

[Evan Stade, 2012-07-13 06:12:05]

lgtm

http://codereview.chromium.org/10702117/diff/10003/chrome/browser/ui/webui/pe...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

http://codereview.chromium.org/10702117/diff/10003/chrome/browser/ui/webui/pe...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:152: EventType
event_type = static_cast<EventType>(static_cast<int>(event));
is this intermediate cast entirely necessary?

http://codereview.chromium.org/10702117/diff/10003/chrome/browser/ui/webui/pe...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:192: MetricType
metric_type = static_cast<MetricType>(static_cast<int>(metric));
ditto

[Matt Tytel, 2012-07-13 19:36:05]

https://chromiumcodereview.appspot.com/10702117/diff/10003/chrome/browser/ui/...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10702117/diff/10003/chrome/browser/ui/...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:152: EventType
event_type = static_cast<EventType>(static_cast<int>(event));
It's lame I know, but necessary because windows doesn't allow static_casts from
double to enum types.

[commit-bot: I haz the power, 2012-07-13 20:02:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtytel@chromium.org/10702117/13008

[Matt Tytel, 2012-07-13 21:02:14]

Unchecking because it's about to bump heads with a commit going in now.

[commit-bot: I haz the power, 2012-07-13 21:37:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtytel@chromium.org/10702117/17001

[commit-bot: I haz the power, 2012-07-13 21:53:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtytel@chromium.org/10702117/20002

[commit-bot: I haz the power, 2012-07-13 22:57:35]

Change committed as 146680