Issue 10702048: Remove the code to wait on disconnected child processes to get the exit code. This was done in r101…

Issue 10702048: Remove the code to wait on disconnected child processes to get the exit code. This was done in r101… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, MAD, jar (doing other things), apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Ilya Sherman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove the code to wait on disconnected child processes to get the exit code. This was done in r101435 to fix a problem where we were seeing processes "quit" but the result code wasn't ready. It looks like r68831 caused this, since it made the channel be disconnected before the process exits. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145676

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : sync #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -183 lines)			Patch
M	chrome/browser/metrics/metrics_service.h	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	1 2 3 4	4 chunks	+5 lines, -12 lines	0 comments	Download
M	content/browser/browser_child_process_host_impl.h	View	1 2 3 4	4 chunks	+1 line, -16 lines	0 comments	Download
M	content/browser/browser_child_process_host_impl.cc	View	1 2 3 4	6 chunks	+5 lines, -70 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.h	View	1 2 3 4	6 chunks	+3 lines, -22 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3 4	4 chunks	+12 lines, -47 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_mac.mm	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/child_thread.cc	View	1 2 3 4	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/public/browser/render_process_host.h	View	1 2 3 4	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm. Also, is the mac files part of this CL? http://codereview.chromium.org/10702048/diff/12003/content/browser/download/download_manager_impl.cc File content/browser/download/download_manager_impl.cc (right): http://codereview.chromium.org/10702048/diff/12003/content/browser/download/download_manager_impl.cc#newcode15 ...

8 years, 5 months ago (2012-07-09 05:14:11 UTC) #2

jam

8 years, 5 months ago (2012-07-09 05:44:06 UTC) #3

http://codereview.chromium.org/10702048/diff/12003/content/browser/download/d...
File content/browser/download/download_manager_impl.cc (right):

http://codereview.chromium.org/10702048/diff/12003/content/browser/download/d...
content/browser/download/download_manager_impl.cc:15: #include
"base/message_loop.h"
On 2012/07/09 05:14:11, cpu wrote:
> does this file belong to this CL?

yeah, this is because of the waitable_event_watcher.h removal from
render_process_host_impl.h

Expand Messages | Collapse Messages