Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: content/common/child_thread.cc

Issue 10702048: Remove the code to wait on disconnected child processes to get the exit code. This was done in r101… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/child_thread.h" 5 #include "content/common/child_thread.h"
6 6
7 #include "base/allocator/allocator_extension.h" 7 #include "base/allocator/allocator_extension.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/process.h" 10 #include "base/process.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 channel_->AddFilter(new ChildTraceMessageFilter()); 64 channel_->AddFilter(new ChildTraceMessageFilter());
65 } 65 }
66 66
67 ChildThread::~ChildThread() { 67 ChildThread::~ChildThread() {
68 #ifdef IPC_MESSAGE_LOG_ENABLED 68 #ifdef IPC_MESSAGE_LOG_ENABLED
69 IPC::Logging::GetInstance()->SetIPCSender(NULL); 69 IPC::Logging::GetInstance()->SetIPCSender(NULL);
70 #endif 70 #endif
71 71
72 channel_->RemoveFilter(sync_message_filter_.get()); 72 channel_->RemoveFilter(sync_message_filter_.get());
73 73
74 // Close this channel before resetting the message loop attached to it so
75 // the message loop can call ChannelProxy::Context::OnChannelClosed(), which
76 // releases the reference count to this channel.
77 channel_->Close();
78
79 // The ChannelProxy object caches a pointer to the IPC thread, so need to 74 // The ChannelProxy object caches a pointer to the IPC thread, so need to
80 // reset it as it's not guaranteed to outlive this object. 75 // reset it as it's not guaranteed to outlive this object.
81 // NOTE: this also has the side-effect of not closing the main IPC channel to 76 // NOTE: this also has the side-effect of not closing the main IPC channel to
82 // the browser process. This is needed because this is the signal that the 77 // the browser process. This is needed because this is the signal that the
83 // browser uses to know that this process has died, so we need it to be alive 78 // browser uses to know that this process has died, so we need it to be alive
84 // until this process is shut down, and the OS closes the handle 79 // until this process is shut down, and the OS closes the handle
85 // automatically. We used to watch the object handle on Windows to do this, 80 // automatically. We used to watch the object handle on Windows to do this,
86 // but it wasn't possible to do so on POSIX. 81 // but it wasn't possible to do so on POSIX.
87 channel_->ClearIPCTaskRunner(); 82 channel_->ClearIPCTaskRunner();
88 } 83 }
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 } 272 }
278 273
279 // The child process shutdown sequence is a request response based mechanism, 274 // The child process shutdown sequence is a request response based mechanism,
280 // where we send out an initial feeler request to the child process host 275 // where we send out an initial feeler request to the child process host
281 // instance in the browser to verify if it's ok to shutdown the child process. 276 // instance in the browser to verify if it's ok to shutdown the child process.
282 // The browser then sends back a response if it's ok to shutdown. This avoids 277 // The browser then sends back a response if it's ok to shutdown. This avoids
283 // race conditions if the process refcount is 0 but there's an IPC message 278 // race conditions if the process refcount is 0 but there's an IPC message
284 // inflight that would addref it. 279 // inflight that would addref it.
285 Send(new ChildProcessHostMsg_ShutdownRequest); 280 Send(new ChildProcessHostMsg_ShutdownRequest);
286 } 281 }
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_view_mac.mm ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698