Merge 144001 - Update BrowserView::ProcessFullscreen OmniboxViewWin use; etc.

Merge 144001 - Update BrowserView::ProcessFullscreen OmniboxViewWin use; etc.

Make OmniboxViewWin code in ProcessFullscreen conditional.
Move OmniboxView util functions to omnibox_views.[h|cc].
Minor refactoring; init OmniboxViewViews::textfield_ to NULL.

BUG=131660, 134263
TEST=Omnibox doesn't trigger crashes after exiting fullscreen.

Review URL: https://chromiumcodereview.appspot.com/10636023

TBR=msw@chromium.org,sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144974

[Peter Kasting, 2012-06-29 20:15:28]

LGTM

https://chromiumcodereview.appspot.com/10702044/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_views.h (right):

https://chromiumcodereview.appspot.com/10702044/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_views.h:20: }
Nit: This views::View forward declaration not needed (or part of your original
trunk change).

[msw, 2012-06-29 20:20:29]

Thanks, Peter! I removed the unnecessary forward decl locally. I'm not sure how
to re-upload the drover patch for review, I'm just going to commit and watch the
waterfall.

https://chromiumcodereview.appspot.com/10702044/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/omnibox/omnibox_views.h (right):

https://chromiumcodereview.appspot.com/10702044/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/omnibox/omnibox_views.h:20: }
On 2012/06/29 20:15:28, Peter Kasting wrote:
> Nit: This views::View forward declaration not needed (or part of your original
> trunk change).

Done.