Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10636023: Update BrowserView::ProcessFullscreen OmniboxViewWin use; etc. (Closed)

Created:
8 years, 6 months ago by msw
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Update BrowserView::ProcessFullscreen OmniboxViewWin use; etc. Make OmniboxViewWin code in ProcessFullscreen conditional. Move OmniboxView util functions to omnibox_views.[h|cc]. Minor refactoring; init OmniboxViewViews::textfield_ to NULL. BUG=131660, 134263 TEST=Omnibox doesn't trigger crashes after exiting fullscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144001

Patch Set 1 #

Patch Set 2 : Sync and merge. #

Patch Set 3 : Sync and merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -38 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 4 chunks +17 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_views.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_views.cc View 1 2 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Scott, please take a look; thanks!
8 years, 6 months ago (2012-06-23 04:24:14 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-25 14:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10636023/3002
8 years, 6 months ago (2012-06-25 19:09:50 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/omnibox/omnibox_view_views.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/views/omnibox/omnibox_view_views.cc ...
8 years, 6 months ago (2012-06-25 19:09:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10636023/5004
8 years, 6 months ago (2012-06-25 19:33:44 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 20:49:48 UTC) #6
Change committed as 144001

Powered by Google App Engine
This is Rietveld 408576698