Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Issue 10702030: Move fullscreen_controller* to a subdirectory (Closed)

Created:
8 years, 5 months ago by scheib
Modified:
8 years, 5 months ago
CC:
chromium-reviews, robertshield, scheib+watch_chromium.org, kkania
Visibility:
Public.

Description

Move fullscreen_controller* to a subdirectory BUG=135052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144971

Patch Set 1 #

Patch Set 2 : merge tot with precursor patches landed. #

Patch Set 3 : Move to browser/ui/fullscreen/ #

Patch Set 4 : merge tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2388 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/fullscreen/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller_test.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_controller_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_exit_bubble.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
A + chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/fullscreen_controller.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/ui/fullscreen_controller.cc View 1 1 chunk +0 lines, -595 lines 0 comments Download
D chrome/browser/ui/fullscreen_controller_browsertest.cc View 1 2 3 1 chunk +0 lines, -390 lines 0 comments Download
D chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc View 1 2 3 1 chunk +0 lines, -513 lines 0 comments Download
D chrome/browser/ui/fullscreen_controller_test.h View 1 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/fullscreen_controller_test.cc View 1 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/browser/ui/fullscreen_exit_bubble.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/ui/fullscreen_exit_bubble.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/ui/fullscreen_exit_bubble_type.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/fullscreen_exit_bubble_type.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheib
sky, could you confirm/note on this issue that you had suggested we move to a ...
8 years, 5 months ago (2012-06-28 22:54:55 UTC) #1
sky
Yes, I like the move but can you name the directory fullscreen. fullscreen_controller is mildly ...
8 years, 5 months ago (2012-06-28 23:18:34 UTC) #2
yzshen1
On 2012/06/28 23:18:34, sky wrote: > Yes, I like the move but can you name ...
8 years, 5 months ago (2012-06-29 16:28:20 UTC) #3
scheib
ben, Owners please.
8 years, 5 months ago (2012-06-29 19:20:42 UTC) #4
Ben Goodger (Google)
8 years, 5 months ago (2012-06-29 19:36:42 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698