Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 10702017: Revert r 144574 "Modify experimental identity flow to display scope descriptions and details." (Closed)

Created:
8 years, 5 months ago by oshima
Modified:
8 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Aaron Boodman, darin-cc_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Revert r 144574 "Modify experimental identity flow to display scope descriptions and details." TBR=estade@chromium.org BUG=130206 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -851 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 4 chunks +2 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 8 chunks +23 lines, -67 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 9 chunks +1 line, -31 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 9 chunks +5 lines, -69 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_navigation_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 5 chunks +4 lines, -31 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 4 chunks +4 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/extension_permission_set.h View 1 chunk +0 lines, -470 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_flow.h View 5 chunks +2 lines, -11 lines 0 comments Download
M chrome/common/net/gaia/oauth2_mint_token_flow.cc View 4 chunks +13 lines, -30 lines 0 comments Download
D chrome/test/data/extensions/browsertest/scopes/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
8 years, 5 months ago (2012-06-27 23:15:04 UTC) #1
oshima
8 years, 5 months ago (2012-06-27 23:17:24 UTC) #2
For the record, here is the asan report.


[ RUN      ] PlatformAppApiTest.Identity
=================================================================
==5734== ERROR: AddressSanitizer heap-use-after-free on address 0x7f07ed09eb20
at pc 0x40e3ac6 bp 0x7ffff8a36950 sp 0x7ffff8a36948
READ of size 1 at 0x7f07ed09eb20 thread T0
    #0 0x40e3ac6 in OAuth2MintTokenFlow::ReportSuccess(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&) ???:0
    #1 0x2db5155 in MessageLoop::RunTask(base::PendingTask const&) ???:0
    #2 0x2db589c in MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
???:0
    #3 0x2db6e02 in MessageLoop::DoWork() ???:0
    #4 0x2e6b976 in
base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*,
base::MessagePumpDispatcher*) ???:0
    #5 0x2db3da2 in MessageLoop::RunInternal() ???:0
    #6 0x2db8031 in
MessageLoopForUI::RunWithDispatcher(base::MessagePumpDispatcher*) ???:0
    #7 0x2d32dbe in ui_test_utils::RunMessageLoop() ???:0
    #8 0x92fcf0 in ExtensionBrowserTest::WaitForExtensionViewsToLoad() ???:0
    #9 0x92f75b in ExtensionBrowserTest::LoadExtensionWithOptions(FilePath
const&, bool, bool) ???:0
    #10 0x927ec7 in ExtensionApiTest::RunExtensionTestImpl(char const*,
std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&,
int) ???:0
    #11 0x927779 in ExtensionApiTest::RunExtensionTest(char const*) ???:0
    #12 0x80f13c in PlatformAppApiTest_Identity_Test::RunTestOnMainThread()
???:0
    #13 0x2d267f0 in InProcessBrowserTest::RunTestOnMainThreadLoop() ???:0
    #14 0x2a1a962 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ???:0
    #15 0x2a16f32 in ChromeBrowserMainParts::PreMainMessageLoopRun() ???:0
    #16 0x7eda707 in content::BrowserMainLoop::CreateThreads() ???:0
    #17 0x817ed96 in (anonymous
namespace)::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams
const&) content/browser/browser_main_runner.cc:0
    #18 0x9a59c9b in BrowserMain(content::MainFunctionParams const&) ???:0
    #19 0x8d0c3df in BrowserTestBase::SetUp() ???:0
    #20 0x2d23733 in InProcessBrowserTest::SetUp() ???:0
    #21 0x356fa71 in testing::Test::Run() ???:0
    #22 0x3571a95 in testing::TestInfo::Run() ???:0
    #23 0x3572e8c in testing::TestCase::Run() ???:0
    #24 0x357f4ec in testing::internal::UnitTestImpl::RunAllTests() ???:0
    #25 0x357ea1c in testing::UnitTest::Run() ???:0
    #26 0x2e98946 in base::TestSuite::Run() ???:0
    #27 0x143ede9 in ChromeTestLauncherDelegate::RunTestSuite(int, char**) ???:0
    #28 0x8dccaec in
test_launcher::LaunchTests(test_launcher::TestLauncherDelegate*, int, char**)
???:0
    #29 0x143e924 in main ???:0
    #30 0x7f07feecec4d in __libc_start_main
/build/buildd/eglibc-2.11.1/csu/libc-start.c:258
0x7f07ed09eb20 is located 160 bytes inside of 184-byte region
[0x7f07ed09ea80,0x7f07ed09eb38)
freed by thread T0 here:
    #0 0x9e177b2 in operator delete(void*) ??:0
    #1 0x3e907e1 in extensions::GetAuthTokenFunction::~GetAuthTokenFunction()
???:0
    #2 0x3c72cab in void
content::BrowserThread::DeleteOnThread<(content::BrowserThread::ID)0>::Destruct<UIThreadExtensionFunction>(UIThreadExtensionFunction
const*) ???:0
    #3 0x40e3a43 in OAuth2MintTokenFlow::ReportSuccess(std::basic_string<char,
std::char_traits<char>, std::allocator<char> > const&) ???:0
    #4 0x2db5155 in MessageLoop::RunTask(base::PendingTask const&) ???:0
    #5 0x2db589c in MessageLoop::DeferOrRunPendingTask(base::PendingTask const&)
???:0
    #6 0x2db6e02 in MessageLoop::DoWork() ???:0
    #7 0x2e6b976 in
base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*,
base::MessagePumpDispatcher*) ???:0
    #8 0x2db3da2 in MessageLoop::RunInternal() ???:0
    #9 0x2db8031 in
MessageLoopForUI::RunWithDispatcher(base::MessagePumpDispatcher*) ???:0
    #10 0x2d32dbe in ui_test_utils::RunMessageLoop() ???:0
    #11 0x92fcf0 in ExtensionBrowserTest::WaitForExtensionViewsToLoad() ???:0
    #12 0x92f75b in ExtensionBrowserTest::LoadExtensionWithOptions(FilePath
const&, bool, bool) ???:0
    #13 0x927ec7 in ExtensionApiTest::RunExtensionTestImpl(char const*,
std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&,
int) ???:0
    #14 0x927779 in ExtensionApiTest::RunExtensionTest(char const*) ???:0
    #15 0x80f13c in PlatformAppApiTest_Identity_Test::RunTestOnMainThread()
???:0
    #16 0x2d267f0 in InProcessBrowserTest::RunTestOnMainThreadLoop() ???:0
    #17 0x2a1a962 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ???:0
    #18 0x2a16f32 in ChromeBrowserMainParts::PreMainMessageLoopRun() ???:0
    #19 0x7eda707 in content::BrowserMainLoop::CreateThreads() ???:0
    #20 0x817ed96 in (anonymous
namespace)::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams
const&) content/browser/browser_main_runner.cc:0
    #21 0x9a59c9b in BrowserMain(content::MainFunctionParams const&) ???:0
    #22 0x8d0c3df in BrowserTestBase::SetUp() ???:0
    #23 0x2d23733 in InProcessBrowserTest::SetUp() ???:0
    #24 0x356fa71 in testing::Test::Run() ???:0
    #25 0x3571a95 in testing::TestInfo::Run() ???:0
    #26 0x3572e8c in testing::TestCase::Run() ???:0
    #27 0x357f4ec in testing::internal::UnitTestImpl::RunAllTests() ???:0
    #28 0x357ea1c in testing::UnitTest::Run() ???:0
    #29 0x2e98946 in base::TestSuite::Run() ???:0
previously allocated by thread T0 here:
    #0 0x9e17632 in operator new(unsigned long) ??:0
    #1 0x3e90b0b in extensions::GetAuthTokenFunction::RunImpl() ???:0
    #2 0x3c72231 in ExtensionFunction::Run() ???:0
    #3 0x3c76959 in
ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&,
content::RenderViewHost*) ???:0
    #4 0x3ca9c98 in ExtensionHost::OnMessageReceived(IPC::Message const&) ???:0
    #5 0x3caa04d in non-virtual thunk to
ExtensionHost::OnMessageReceived(IPC::Message const&) ???:0
    #6 0x810b25e in WebContentsImpl::OnMessageReceived(IPC::Message const&)
???:0
    #7 0x81103cd in non-virtual thunk to
WebContentsImpl::OnMessageReceived(IPC::Message const&) ???:0
    #8 0x8042e9f in content::RenderViewHostImpl::OnMessageReceived(IPC::Message
const&) ???:0
    #9 0x804bb2d in non-virtual thunk to
content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) ???:0
    #10 0x8025ab6 in
content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) ???:0
    #11 0x802681d in non-virtual thunk to
content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) ???:0
    #12 0x419c085 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message
const&) ???:0
    #13 0x2db5155 in MessageLoop::RunTask(base::PendingTask const&) ???:0
    #14 0x2db589c in MessageLoop::DeferOrRunPendingTask(base::PendingTask
const&) ???:0
    #15 0x2db6e02 in MessageLoop::DoWork() ???:0
    #16 0x2e6b049 in (anonymous namespace)::WorkSourceDispatch(_GSource*, int
(*)(void*), void*) base/message_pump_glib.cc:0
    #17 0x7f08034418c2 in g_main_dispatch
/build/buildd/glib2.0-2.24.1/glib/gmain.c:1960

Powered by Google App Engine
This is Rietveld 408576698