Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10701165: Revert 146303 - Disables allocator_shim on Windows memory builders. (Closed)

Created:
8 years, 5 months ago by Hironori Bono
Modified:
8 years, 5 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 146303 - Disables allocator_shim on Windows memory builders. This change disables allocator_shim on Windows memory builders because it causes a linker error with the latest ANGLE code as reported by Erik (*1). Allocator_shim is disabled on shared builds and it happens only on memory builders, which use static builds. (All the other Windows debug builders use shared builds.) (*1) https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/4197e93c6f5814ef/330ea8d9d31141e1?lnk=gst&q=base%2Fallocator+#330ea8d9d31141e1 BUG=none TEST=build unit_tests.exe on the "Windows Tests (tsan)" bot and the "Chromium Windows Builder (DrMemory)" bot. Review URL: https://chromiumcodereview.appspot.com/10704178 TBR=hbono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hironori Bono
8 years, 5 months ago (2012-07-13 00:40:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698