Issue 10704178: Disables allocator_shim on Windows memory builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704178: Disables allocator_shim on Windows memory builders. (Closed)

Created:
8 years, 5 months ago by Hironori Bono

Modified:
8 years, 5 months ago

Reviewers:
Reid Kleckner, Alexander Potapenko, Reid Kleckner (google), Timur Iskhodzhanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disables allocator_shim on Windows memory builders. This change disables allocator_shim on Windows memory builders because it causes a linker error with the latest ANGLE code as reported by Erik (*1). Allocator_shim is disabled on shared builds and it happens only on memory builders, which use static builds. (All the other Windows debug builders use shared builds.) (*1) https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/4197e93c6f5814ef/330ea8d9d31141e1?lnk=gst&q=base%2Fallocator+#330ea8d9d31141e1 BUG=none TEST=build unit_tests.exe on the "Windows Tests (tsan)" bot and the "Chromium Windows Builder (DrMemory)" bot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146303

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Reid Kleckner (google)

8 years, 5 months ago (2012-07-12 13:09:04 UTC) #3

LGTM

This should cause us to use the normal Windows heap, according to the
common.gypi comments.  Long term someone should implement _realloc_dbg in
generic_allocators.cc.  I don't want to make our special build too special.

On Thu, Jul 12, 2012 at 1:32 AM, Timur Iskhodzhanov
<timurrrr@chromium.org>wrote:

> LGTM if you know what you're doing :)
>

Expand Messages | Collapse Messages