Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10700202: Add Android stub implementation for AppNotifyChannelUI (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
Reviewers:
Yoyo Zhou, Jay Civelli
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Add Android stub implementation for AppNotifyChannelUI - Split the interface and implementation in different .h files - Provide an android stub implementation as the default implementation depends on Browser BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146694

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Added a Create method to the interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -296 lines) Patch
M chrome/browser/extensions/app_notify_channel_ui.h View 1 2 2 chunks +5 lines, -52 lines 0 comments Download
D chrome/browser/extensions/app_notify_channel_ui.cc View 1 chunk +0 lines, -201 lines 0 comments Download
A chrome/browser/extensions/app_notify_channel_ui_android.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/extensions/app_notify_channel_ui_android.cc View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/app_notify_channel_ui_impl.h View 2 chunks +4 lines, -34 lines 0 comments Download
A + chrome/browser/extensions/app_notify_channel_ui_impl.cc View 1 2 4 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nilesh
8 years, 5 months ago (2012-07-13 19:13:26 UTC) #1
Jay Civelli
http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/extension_tab_helper.cc File chrome/browser/extensions/extension_tab_helper.cc (right): http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/extension_tab_helper.cc#newcode306 chrome/browser/extensions/extension_tab_helper.cc:306: AppNotifyChannelUI* ui = new AppNotifyChannelUIAndroid(); If you added a ...
8 years, 5 months ago (2012-07-13 20:04:14 UTC) #2
Yoyo Zhou
mostly LGTM but for jcivelli's comment http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/app_notify_channel_ui.h File chrome/browser/extensions/app_notify_channel_ui.h (right): http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/app_notify_channel_ui.h#newcode8 chrome/browser/extensions/app_notify_channel_ui.h:8: #include "base/basictypes.h" This ...
8 years, 5 months ago (2012-07-13 20:47:33 UTC) #3
nilesh
Thanks for the review. Comments addressed. http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/app_notify_channel_ui.h File chrome/browser/extensions/app_notify_channel_ui.h (right): http://codereview.chromium.org/10700202/diff/4002/chrome/browser/extensions/app_notify_channel_ui.h#newcode8 chrome/browser/extensions/app_notify_channel_ui.h:8: #include "base/basictypes.h" On ...
8 years, 5 months ago (2012-07-13 21:25:30 UTC) #4
Jay Civelli
lgtm
8 years, 5 months ago (2012-07-13 21:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10700202/14001
8 years, 5 months ago (2012-07-13 21:28:12 UTC) #6
commit-bot: I haz the power
Try job failure for 10700202-14001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-13 22:43:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10700202/14001
8 years, 5 months ago (2012-07-13 22:58:00 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-14 01:04:39 UTC) #9
Change committed as 146694

Powered by Google App Engine
This is Rietveld 408576698