chrome/browser/extensions/api/serial/serial_api.cc - Issue 10700194: Represent BINARY properties using std::string instead of BinaryValue,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_api.cc

Issue 10700194: Represent BINARY properties using std::string instead of BinaryValue, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_api.cc

diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc

index 77d4c51b61b8c36a1e4e69ed5ced204694b0b0c3..ef6833137c3d0410fad34b9aec365b2d29a8e23e 100644

--- a/chrome/browser/extensions/api/serial/serial_api.cc

+++ b/chrome/browser/extensions/api/serial/serial_api.cc

@@ -215,8 +215,8 @@ bool SerialWriteFunction::Prepare() {

params_ = api::experimental_serial::Write::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params_.get());

- io_buffer_size_ = params_->data->GetSize();

- io_buffer_ = new net::WrappedIOBuffer(params_->data->GetBuffer());

+ io_buffer_size_ = params_->data.size();

+ io_buffer_ = new net::WrappedIOBuffer(params_->data.data());

return true;

}