Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 10700183: Use isfinite() on all POSIX platforms (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use isfinite() on all POSIX platforms Based on some research online, it appears this should work everywhere. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146361

Patch Set 1 #

Patch Set 2 : Keep the old path for Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M base/float_util.h View 1 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stuartmorgan
This is the follow-up to our discussion in http://codereview.chromium.org/10704126/ I did some more looking, and ...
8 years, 5 months ago (2012-07-12 12:33:23 UTC) #1
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-12 13:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10700183/1
8 years, 5 months ago (2012-07-12 13:14:01 UTC) #3
commit-bot: I haz the power
Try job failure for 10700183-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 5 months ago (2012-07-12 13:26:20 UTC) #4
stuartmorgan
Huh. Checking with some local Android folks...
8 years, 5 months ago (2012-07-12 13:34:23 UTC) #5
stuartmorgan
Apparently Android has a Solaris-style bug where an include chain brings in a cmath.h that ...
8 years, 5 months ago (2012-07-12 14:31:07 UTC) #6
Mark Mentovai
LGTM again
8 years, 5 months ago (2012-07-12 14:53:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10700183/8002
8 years, 5 months ago (2012-07-12 14:53:35 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 16:25:50 UTC) #9
Change committed as 146361

Powered by Google App Engine
This is Rietveld 408576698