Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3062)

Unified Diff: base/float_util.h

Issue 10700183: Use isfinite() on all POSIX platforms (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Keep the old path for Android Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/float_util.h
diff --git a/base/float_util.h b/base/float_util.h
index 39b92028ee8d9903b9a5f37a88a9c9093d5231c9..31a307dbf5cc762ce8c7c7b07dfbbf82337613e1 100644
--- a/base/float_util.h
+++ b/base/float_util.h
@@ -10,19 +10,14 @@
#include <float.h>
#include <math.h>
-#if defined(OS_SOLARIS)
-#include <ieeefp.h>
-#endif
-
namespace base {
inline bool IsFinite(const double& number) {
-#if defined(OS_MACOSX)
- // C99 says isfinite() replaced finite(), and iOS does not provide the
- // older call.
- return isfinite(number) != 0;
-#elif defined(OS_POSIX)
+#if defined(OS_ANDROID)
+ // isfinite isn't available on Android: http://b.android.com/34793
return finite(number) != 0;
+#elif defined(OS_POSIX)
+ return isfinite(number) != 0;
#elif defined(OS_WIN)
return _finite(number) != 0;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698