Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10700170: Fix transferring processes during a redirect. (Closed)

Created:
8 years, 5 months ago by darin (slow to review)
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Matt Perry, Charlie Reis
Visibility:
Public.

Description

Fix transferring processes during a redirect. This change adds a WillCompleteTransfer method on ResourceLoader. The ResourceLoader uses this signal to reset the ResourceHandler, which causes the destruction of the old AsyncResourceHandler. That in turn results in clearing the "async_handler" member of the ResourceRequestInfoImpl. What was happening before this change is that the destruction of the old AsyncResourceHandler was happening too late. When it cleared the "async_handler" member, it was clearing it on the newly constructed ResourceRequestInfoImpl object. As a result, when the OnFollowRedirect IPC finally arrives, it finds that the "async_handler" member is null. R=jam@chromium.org BUG=136630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146416

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -52 lines) Patch
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 16 chunks +197 lines, -52 lines 0 comments Download
M content/browser/renderer_host/resource_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/resource_loader.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
I'm not quite sure how to write an automated test for this yet. Apparently, the ...
8 years, 5 months ago (2012-07-11 23:01:53 UTC) #1
darin (slow to review)
Now with a couple unit tests. (Actually, these are really integration tests of the ResourceDispatcherHost ...
8 years, 5 months ago (2012-07-12 07:04:10 UTC) #2
darin (slow to review)
+mpcomplete,creis: FYI
8 years, 5 months ago (2012-07-12 07:06:11 UTC) #3
jam
lgtm
8 years, 5 months ago (2012-07-12 18:54:37 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 18:59:09 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698