Don't actually create Handles for the constant hole.

Don't actually create Handles for the constant hole, the true value and the false value.  This is required to have some parts of Crankshaft run without creating Handles.


BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11980

[Michael Starzinger, 2012-07-02 20:11:20]

This is a little bit hacky, let's make that cleaner. Also, the description no
longer applies once my comments are addressed.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:571: Object* value) {
Turn the second parameter into "Handle<Object> value"

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:583: return GetConstant(&constant_1_, Smi::FromInt(1));
Use "Handle<Smi>(Smi::FromInt(1))" here.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:588: return GetConstant(&constant_minus1_, Smi::FromInt(-1));
Likewise.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:593: return GetConstant(&constant_true_,
isolate()->heap()->true_value());
Use "isolate->factory()->true_value()" here.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:598: return GetConstant(&constant_false_,
isolate()->heap()->false_value());
Likewise.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:605:
&isolate()->heap()->roots_array_start()[Heap::kTheHoleValueRootIndex]);
Likewise.

[sanjoy, 2012-07-03 09:05:52]

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:571: Object* value) {
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Turn the second parameter into "Handle<Object> value"

Done.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:583: return GetConstant(&constant_1_, Smi::FromInt(1));
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Use "Handle<Smi>(Smi::FromInt(1))" here.

Done.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:588: return GetConstant(&constant_minus1_, Smi::FromInt(-1));
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Likewise.

Done.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:593: return GetConstant(&constant_true_,
isolate()->heap()->true_value());
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Use "isolate->factory()->true_value()" here.

Done.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:598: return GetConstant(&constant_false_,
isolate()->heap()->false_value());
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Likewise.

Done.

https://chromiumcodereview.appspot.com/10699052/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:605:
&isolate()->heap()->roots_array_start()[Heap::kTheHoleValueRootIndex]);
On 2012/07/02 20:11:20, Michael Starzinger wrote:
> Likewise.

Done.

[Michael Starzinger, 2012-07-03 09:20:09]

https://chromiumcodereview.appspot.com/10699052/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10699052/diff/5001/src/hydrogen.cc#new...
src/hydrogen.cc:603: if (!constant_hole_.is_set()) {
Is there a particular reason we need the special handling for the hole value?
Can't we just use GetConstant() instead of this whole block now?

[sanjoy, 2012-07-03 09:32:00]

https://chromiumcodereview.appspot.com/10699052/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10699052/diff/5001/src/hydrogen.cc#new...
src/hydrogen.cc:603: if (!constant_hole_.is_set()) {
On 2012/07/03 09:20:09, Michael Starzinger wrote:
> Is there a particular reason we need the special handling for the hole value?
> Can't we just use GetConstant() instead of this whole block now?

No there isn't and yes we should.  Fixed.

[Michael Starzinger, 2012-07-03 09:40:41]

LGTM.