Don't actually create Handles for the constant hole.

src/hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 550 matching lines @@
         ASSERT(!dominator_analyzer.reachable()->Contains(block->block_id()));
       }
     }
   }
 }
 
 #endif
 
 
 HConstant* HGraph::GetConstant(SetOncePointer<HConstant>* pointer,
                                Object* value) {

[Michael Starzinger, 2012/07/02 20:11:20]

Turn the second parameter into "Handle<Object> value"

[sanjoy, 2012/07/03 09:05:52]

Done.

   if (!pointer->is_set()) {
     HConstant* constant = new(zone()) HConstant(Handle<Object>(value),
                                                 Representation::Tagged());
     constant->InsertAfter(GetConstantUndefined());
     pointer->set(constant);
   }
   return pointer->get();
 }
 
 
 HConstant* HGraph::GetConstant1() {
   return GetConstant(&constant_1_, Smi::FromInt(1));

[Michael Starzinger, 2012/07/02 20:11:20]

Use "Handle<Smi>(Smi::FromInt(1))" here.

[sanjoy, 2012/07/03 09:05:52]

Done.

 }
 
 
 HConstant* HGraph::GetConstantMinus1() {
   return GetConstant(&constant_minus1_, Smi::FromInt(-1));

[Michael Starzinger, 2012/07/02 20:11:20]

Likewise.

[sanjoy, 2012/07/03 09:05:52]

Done.

 }
 
 
 HConstant* HGraph::GetConstantTrue() {
   return GetConstant(&constant_true_, isolate()->heap()->true_value());

[Michael Starzinger, 2012/07/02 20:11:20]

Use "isolate->factory()->true_value()" here.

[sanjoy, 2012/07/03 09:05:52]

Done.

 }
 
 
 HConstant* HGraph::GetConstantFalse() {
   return GetConstant(&constant_false_, isolate()->heap()->false_value());

[Michael Starzinger, 2012/07/02 20:11:20]

Likewise.

[sanjoy, 2012/07/03 09:05:52]

Done.

 }
 
 
 HConstant* HGraph::GetConstantHole() {
-  return GetConstant(&constant_hole_, isolate()->heap()->the_hole_value());
+  if (!constant_hole_.is_set()) {
+    Handle<Object> hole_value = Handle<Object>(
+        &isolate()->heap()->roots_array_start()[Heap::kTheHoleValueRootIndex]);

[Michael Starzinger, 2012/07/02 20:11:20]

Likewise.

[sanjoy, 2012/07/03 09:05:52]

Done.

+    HConstant* constant = new(zone()) HConstant(hole_value,
+                                                Representation::Tagged());
+    constant->InsertAfter(GetConstantUndefined());
+    constant_hole_.set(constant);
+  }
+  return constant_hole_.get();
 }
 
 
 HGraphBuilder::HGraphBuilder(CompilationInfo* info,
                              TypeFeedbackOracle* oracle)
     : function_state_(NULL),
       initial_function_state_(this, info, oracle, NORMAL_RETURN),
       ast_context_(NULL),
       break_scope_(NULL),
       graph_(NULL),
@@ skipping 8904 matching lines @@
     }
   }
 
 #ifdef DEBUG
   if (graph_ != NULL) graph_->Verify(false);  // No full verify.
   if (allocator_ != NULL) allocator_->Verify();
 #endif
 }
 
 } }  // namespace v8::internal