[Sync] Move sync/{internal_api,syncable} into syncer namespace

[Sync] Move sync/{internal_api,syncable} into syncer namespace

Add temporary aliases from syncable::* to syncer::syncable::* for
ModelType and related classes until those are ported to syncer proper.

Disambiguate names in MockConnectionManager.

BUG=128060
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145211

[akalin, 2012-06-30 01:34:17]

+rlarocque for review

[rlarocque, 2012-07-02 17:42:55]

What do we gain by moving from syncable:: to syncer::syncable:: if we intend to
rename them again soon?

[akalin, 2012-07-02 18:18:55]

On 2012/07/02 17:42:55, rlarocque wrote:
> What do we gain by moving from syncable:: to syncer::syncable:: if we intend
to
> rename them again soon?

That's only for ModelType and related classes (ModelTypeSet, etc.).  Everything
else will remain in syncer::syncable.  Updated CL description to be clearer.

[rlarocque, 2012-07-02 18:42:02]

LGTM.

https://chromiumcodereview.appspot.com/10699044/diff/1/sync/sessions/ordered_...
File sync/sessions/ordered_commit_set_unittest.cc (right):

https://chromiumcodereview.appspot.com/10699044/diff/1/sync/sessions/ordered_...
sync/sessions/ordered_commit_set_unittest.cc:13: namespace {
This (anonymous namespace) looks like a good idea.  Why don't we do this for all
tests?

(You don't have to do it now, I'm just wondering if we should aim to put all
tests in anonymous namespaces eventually.)

[akalin, 2012-07-02 18:44:53]

https://chromiumcodereview.appspot.com/10699044/diff/1/sync/sessions/ordered_...
File sync/sessions/ordered_commit_set_unittest.cc (right):

https://chromiumcodereview.appspot.com/10699044/diff/1/sync/sessions/ordered_...
sync/sessions/ordered_commit_set_unittest.cc:13: namespace {
On 2012/07/02 18:42:02, rlarocque wrote:
> This (anonymous namespace) looks like a good idea.  Why don't we do this for
all
> tests?
> 
> (You don't have to do it now, I'm just wondering if we should aim to put all
> tests in anonymous namespaces eventually.)

We should.  ODR violations in test helper class names are a real possibility
(e.g., I believe it's happened multiple times that a class named 'FakeFoo' or
something was defined in more than one test file).

I think it's just an awareness issue.  The anon namespace pattern is in the
gmock documentation.  Maybe it should be mentioned in the style guide or
something.

[commit-bot: I haz the power, 2012-07-02 18:45:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10699044/1

[commit-bot: I haz the power, 2012-07-02 18:47:07]

Failed to apply patch for sync/test/engine/mock_connection_manager.cc:
While running patch -p1 --forward --force;
patching file sync/test/engine/mock_connection_manager.cc
Hunk #12 FAILED at 474.
Hunk #14 succeeded at 518 with fuzz 1.
1 out of 15 hunks FAILED -- saving rejects to file
sync/test/engine/mock_connection_manager.cc.rej

[commit-bot: I haz the power, 2012-07-02 20:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/10699044/8002

[commit-bot: I haz the power, 2012-07-02 21:13:05]

Try job failure for 10699044-8002 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...