[Sync] Move sync/{internal_api,syncable} into syncer namespace

sync/sessions/ordered_commit_set_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/sessions/ordered_commit_set.h"
 #include "sync/test/engine/test_id_factory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using std::vector;
 
+namespace syncer {
+namespace sessions {
+namespace {

[rlarocque, 2012/07/02 18:42:02]

This (anonymous namespace) looks like a good idea.  Why don't we do this for all
tests?

(You don't have to do it now, I'm just wondering if we should aim to put all
tests in anonymous namespaces eventually.)

[akalin, 2012/07/02 18:44:53]

We should.  ODR violations in test helper class names are a real possibility
(e.g., I believe it's happened multiple times that a class named 'FakeFoo' or
something was defined in more than one test file).

I think it's just an awareness issue.  The anon namespace pattern is in the
gmock documentation.  Maybe it should be mentioned in the style guide or
something.

+
 class OrderedCommitSetTest : public testing::Test {
  public:
   OrderedCommitSetTest() {
     routes_[syncable::BOOKMARKS] = syncer::GROUP_UI;
     routes_[syncable::PREFERENCES] = syncer::GROUP_UI;
     routes_[syncable::AUTOFILL] = syncer::GROUP_DB;
     routes_[syncable::TOP_LEVEL_FOLDER] = syncer::GROUP_PASSIVE;
   }
  protected:
   syncer::TestIdFactory ids_;
   syncer::ModelSafeRoutingInfo routes_;
 };
 
-namespace syncer {
-namespace sessions {
-
 TEST_F(OrderedCommitSetTest, Projections) {
   vector<syncable::Id> expected;
   for (int i = 0; i < 8; i++)
     expected.push_back(ids_.NewLocalId());
 
   OrderedCommitSet commit_set1(routes_), commit_set2(routes_);
   commit_set1.AddCommitItem(0, expected[0], syncable::BOOKMARKS);
   commit_set1.AddCommitItem(1, expected[1], syncable::BOOKMARKS);
   commit_set1.AddCommitItem(2, expected[2], syncable::PREFERENCES);
   // Duplicates should be dropped.
@@ skipping 83 matching lines @@
 
   ASSERT_TRUE(commit_set.Empty());
 
   commit_set.AddCommitItem(0, ids_.NewLocalId(), syncable::AUTOFILL);
   ASSERT_EQ(static_cast<size_t>(1), commit_set.Size());
 
   commit_set.Clear();
   ASSERT_TRUE(commit_set.Empty());
 }
 
+}  // namespace
 }  // namespace sessions
 }  // namespace syncer
-