Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10698141: Revert 145993 - [Sync] Add location parameter to SyncChange in Sync API. (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 5 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Revert 145993 - [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10766016 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -193 lines) Patch
M chrome/browser/extensions/app_notification_manager.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager_sync_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/app_sync_bundle.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 12 chunks +20 lines, -36 lines 0 comments Download
M chrome/browser/extensions/extension_sync_bundle.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_sync_util.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 17 chunks +22 lines, -48 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M sync/api/sync_change.h View 3 chunks +1 line, -7 lines 0 comments Download
M sync/api/sync_change.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M sync/api/sync_change_unittest.cc View 6 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
8 years, 5 months ago (2012-07-10 23:53:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698