Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: sync/api/sync_change_unittest.cc

Issue 10698141: Revert 145993 - [Sync] Add location parameter to SyncChange in Sync API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/api/sync_change.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/api/sync_change.h" 5 #include "sync/api/sync_change.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "sync/protocol/preference_specifics.pb.h" 11 #include "sync/protocol/preference_specifics.pb.h"
12 #include "sync/protocol/proto_value_conversions.h" 12 #include "sync/protocol/proto_value_conversions.h"
13 #include "sync/protocol/sync.pb.h" 13 #include "sync/protocol/sync.pb.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace syncer { 16 namespace syncer {
17 17
18 // Ordered list of SyncChange's. 18 // Ordered list of SyncChange's.
19 typedef std::vector<SyncChange> SyncChangeList; 19 typedef std::vector<SyncChange> SyncChangeList;
20 20
21 namespace { 21 namespace {
22 22
23 typedef testing::Test SyncChangeTest; 23 typedef testing::Test SyncChangeTest;
24 24
25 TEST_F(SyncChangeTest, LocalDelete) { 25 TEST_F(SyncChangeTest, LocalDelete) {
26 SyncChange::SyncChangeType change_type = SyncChange::ACTION_DELETE; 26 SyncChange::SyncChangeType change_type = SyncChange::ACTION_DELETE;
27 std::string tag = "client_tag"; 27 std::string tag = "client_tag";
28 SyncChange e(FROM_HERE, 28 SyncChange e(change_type,
29 change_type,
30 SyncData::CreateLocalDelete(tag, syncer::PREFERENCES)); 29 SyncData::CreateLocalDelete(tag, syncer::PREFERENCES));
31 EXPECT_EQ(change_type, e.change_type()); 30 EXPECT_EQ(change_type, e.change_type());
32 EXPECT_EQ(tag, e.sync_data().GetTag()); 31 EXPECT_EQ(tag, e.sync_data().GetTag());
33 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType()); 32 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType());
34 } 33 }
35 34
36 TEST_F(SyncChangeTest, LocalUpdate) { 35 TEST_F(SyncChangeTest, LocalUpdate) {
37 SyncChange::SyncChangeType change_type = SyncChange::ACTION_UPDATE; 36 SyncChange::SyncChangeType change_type = SyncChange::ACTION_UPDATE;
38 sync_pb::EntitySpecifics specifics; 37 sync_pb::EntitySpecifics specifics;
39 sync_pb::PreferenceSpecifics* pref_specifics = specifics.mutable_preference(); 38 sync_pb::PreferenceSpecifics* pref_specifics = specifics.mutable_preference();
40 pref_specifics->set_name("test"); 39 pref_specifics->set_name("test");
41 std::string tag = "client_tag"; 40 std::string tag = "client_tag";
42 std::string title = "client_title"; 41 std::string title = "client_title";
43 SyncChange e(FROM_HERE, 42 SyncChange e(change_type,
44 change_type,
45 SyncData::CreateLocalData(tag, title, specifics)); 43 SyncData::CreateLocalData(tag, title, specifics));
46 EXPECT_EQ(change_type, e.change_type()); 44 EXPECT_EQ(change_type, e.change_type());
47 EXPECT_EQ(tag, e.sync_data().GetTag()); 45 EXPECT_EQ(tag, e.sync_data().GetTag());
48 EXPECT_EQ(title, e.sync_data().GetTitle()); 46 EXPECT_EQ(title, e.sync_data().GetTitle());
49 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType()); 47 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType());
50 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics)); 48 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
51 scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue( 49 scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue(
52 e.sync_data().GetSpecifics())); 50 e.sync_data().GetSpecifics()));
53 EXPECT_TRUE(ref_spec->Equals(e_spec.get())); 51 EXPECT_TRUE(ref_spec->Equals(e_spec.get()));
54 } 52 }
55 53
56 TEST_F(SyncChangeTest, LocalAdd) { 54 TEST_F(SyncChangeTest, LocalAdd) {
57 SyncChange::SyncChangeType change_type = SyncChange::ACTION_ADD; 55 SyncChange::SyncChangeType change_type = SyncChange::ACTION_ADD;
58 sync_pb::EntitySpecifics specifics; 56 sync_pb::EntitySpecifics specifics;
59 sync_pb::PreferenceSpecifics* pref_specifics = specifics.mutable_preference(); 57 sync_pb::PreferenceSpecifics* pref_specifics = specifics.mutable_preference();
60 pref_specifics->set_name("test"); 58 pref_specifics->set_name("test");
61 std::string tag = "client_tag"; 59 std::string tag = "client_tag";
62 std::string title = "client_title"; 60 std::string title = "client_title";
63 SyncChange e(FROM_HERE, 61 SyncChange e(change_type,
64 change_type,
65 SyncData::CreateLocalData(tag, title, specifics)); 62 SyncData::CreateLocalData(tag, title, specifics));
66 EXPECT_EQ(change_type, e.change_type()); 63 EXPECT_EQ(change_type, e.change_type());
67 EXPECT_EQ(tag, e.sync_data().GetTag()); 64 EXPECT_EQ(tag, e.sync_data().GetTag());
68 EXPECT_EQ(title, e.sync_data().GetTitle()); 65 EXPECT_EQ(title, e.sync_data().GetTitle());
69 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType()); 66 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType());
70 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics)); 67 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
71 scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue( 68 scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue(
72 e.sync_data().GetSpecifics())); 69 e.sync_data().GetSpecifics()));
73 EXPECT_TRUE(ref_spec->Equals(e_spec.get())); 70 EXPECT_TRUE(ref_spec->Equals(e_spec.get()));
74 } 71 }
75 72
76 TEST_F(SyncChangeTest, SyncerChanges) { 73 TEST_F(SyncChangeTest, SyncerChanges) {
77 SyncChangeList change_list; 74 SyncChangeList change_list;
78 75
79 // Create an update. 76 // Create an update.
80 sync_pb::EntitySpecifics update_specifics; 77 sync_pb::EntitySpecifics update_specifics;
81 sync_pb::PreferenceSpecifics* pref_specifics = 78 sync_pb::PreferenceSpecifics* pref_specifics =
82 update_specifics.mutable_preference(); 79 update_specifics.mutable_preference();
83 pref_specifics->set_name("update"); 80 pref_specifics->set_name("update");
84 change_list.push_back(SyncChange( 81 change_list.push_back(SyncChange(
85 FROM_HERE,
86 SyncChange::ACTION_UPDATE, 82 SyncChange::ACTION_UPDATE,
87 SyncData::CreateRemoteData(1, update_specifics))); 83 SyncData::CreateRemoteData(1, update_specifics)));
88 84
89 // Create an add. 85 // Create an add.
90 sync_pb::EntitySpecifics add_specifics; 86 sync_pb::EntitySpecifics add_specifics;
91 pref_specifics = add_specifics.mutable_preference(); 87 pref_specifics = add_specifics.mutable_preference();
92 pref_specifics->set_name("add"); 88 pref_specifics->set_name("add");
93 change_list.push_back(SyncChange( 89 change_list.push_back(SyncChange(
94 FROM_HERE,
95 SyncChange::ACTION_ADD, 90 SyncChange::ACTION_ADD,
96 SyncData::CreateRemoteData(2, add_specifics))); 91 SyncData::CreateRemoteData(2, add_specifics)));
97 92
98 // Create a delete. 93 // Create a delete.
99 sync_pb::EntitySpecifics delete_specifics; 94 sync_pb::EntitySpecifics delete_specifics;
100 pref_specifics = delete_specifics.mutable_preference(); 95 pref_specifics = delete_specifics.mutable_preference();
101 pref_specifics->set_name("add"); 96 pref_specifics->set_name("add");
102 change_list.push_back(SyncChange( 97 change_list.push_back(SyncChange(
103 FROM_HERE,
104 SyncChange::ACTION_DELETE, 98 SyncChange::ACTION_DELETE,
105 SyncData::CreateRemoteData(3, delete_specifics))); 99 SyncData::CreateRemoteData(3, delete_specifics)));
106 100
107 ASSERT_EQ(3U, change_list.size()); 101 ASSERT_EQ(3U, change_list.size());
108 102
109 // Verify update. 103 // Verify update.
110 SyncChange e = change_list[0]; 104 SyncChange e = change_list[0];
111 EXPECT_EQ(SyncChange::ACTION_UPDATE, e.change_type()); 105 EXPECT_EQ(SyncChange::ACTION_UPDATE, e.change_type());
112 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType()); 106 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType());
113 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue( 107 scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(
(...skipping 15 matching lines...) Expand all
129 EXPECT_EQ(SyncChange::ACTION_DELETE, e.change_type()); 123 EXPECT_EQ(SyncChange::ACTION_DELETE, e.change_type());
130 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType()); 124 EXPECT_EQ(syncer::PREFERENCES, e.sync_data().GetDataType());
131 ref_spec.reset(EntitySpecificsToValue(delete_specifics)); 125 ref_spec.reset(EntitySpecificsToValue(delete_specifics));
132 e_spec.reset(EntitySpecificsToValue(e.sync_data().GetSpecifics())); 126 e_spec.reset(EntitySpecificsToValue(e.sync_data().GetSpecifics()));
133 EXPECT_TRUE(ref_spec->Equals(e_spec.get())); 127 EXPECT_TRUE(ref_spec->Equals(e_spec.get()));
134 } 128 }
135 129
136 } // namespace 130 } // namespace
137 131
138 } // namespace syncer 132 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/api/sync_change.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698