src/debug.cc - Issue 10698103: Larger stack trace string in the minidump when catching Debug::Break crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 10698103: Larger stack trace string in the minidump when catching Debug::Break crash. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 1f5164f6ac3dc496b205494695bac3bb8b4fd330..777e23dac81a476d16ea77fbb4558be98ae98d43 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -1027,8 +1027,8 @@ Object* Debug::Break(Arguments args) {

} else if (it.frame()->fp() != thread_local_.last_fp_) {

// We crawled over last_fp_, without getting a match.

Handle<String> stack = isolate_->StackTraceString();

- char buffer[2048];

- String::WriteToFlat(*stack, buffer, 0, 2047);

+ char buffer[8192];

+ String::WriteToFlat(*stack, buffer, 0, 8191);

PutValuesOnStackAndDie(0xDEEEEEEE,

frame->fp(),

thread_local_.last_fp_,

« no previous file with comments | « no previous file | no next file » | no next file with comments »